Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add python 3 support #853

Merged
merged 1 commit into from
Jun 28, 2018
Merged

Add python 3 support #853

merged 1 commit into from
Jun 28, 2018

Conversation

nikolas
Copy link
Member

@nikolas nikolas commented Jun 22, 2018

No description provided.

@nikolas nikolas force-pushed the python3 branch 2 times, most recently from 0b598ec to d887f56 Compare June 22, 2018 15:30
@nikolas
Copy link
Member Author

nikolas commented Jun 22, 2018

The issue here is the enum feature: python 2 needs enum34, but including this package causes a failure on python 3: https://bitbucket.org/stoneleaf/enum34/issues/21/setuppy-should-no-op-for-python-34

@nikolas
Copy link
Member Author

nikolas commented Jun 22, 2018

I solved that issue by adding an environment marker to not install enum34 on newer python 3 versions: https://stackoverflow.com/a/33451105/173630

@nbuonin
Copy link
Contributor

nbuonin commented Jun 22, 2018

I can't get this to build on High Sierra. It fails when it tries to compile librabbitmq. It looks the same as this issue

@nbuonin nbuonin merged commit 19b8631 into master Jun 28, 2018
@nbuonin nbuonin deleted the python3 branch June 28, 2018 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikolas @nbuonin