Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rule checking for SQS visbility timeout being correctly sized in a Lambda EventSourceMapping #1798

Closed
1 of 2 tasks
robert-hanuschke opened this issue Oct 10, 2024 · 0 comments · Fixed by #1813
Closed
1 of 2 tasks
Labels
feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.

Comments

@robert-hanuschke
Copy link
Contributor

Description

Recommendation in the SQS docs:

To allow your function time to process each batch of records, set the source queue's visibility timeout to at least six times the timeout that you configure on your function. The extra time allows for Lambda to retry if your function is throttled while processing a previous batch.

There currently is no rule checking this.

Use Case

Having a rule for this check can prevent configurations resulting in duplicate processing of queue items due to visibility timeout being too low.

Proposed Solution

Rule that checks Lambda CfnEventSourceMappings for an associated SQS CfnQueue and compares the visibilityTimeout setting to the Lambda CfnFunction timeout setting.

Other information

I think I can implement this and would like to start working on it.

Acknowledge

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@robert-hanuschke robert-hanuschke added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 10, 2024
@mergify mergify bot closed this as completed in #1813 Nov 1, 2024
@mergify mergify bot closed this as completed in bfa2820 Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant