Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add code examples for properties #435

Merged
merged 4 commits into from
Sep 13, 2021
Merged

Conversation

Chriscbr
Copy link
Contributor

@Chriscbr Chriscbr commented Sep 11, 2021

Add code examples for all properties within "Properties" sections. This does not add code examples for parameters (e.g. for fields in constructors or methods).

Even though the code examples include the types of the properties, we cannot remove the "Type: xxx" labels below them because they may include links to other types, and code snippets cannot include links in GitHub markdown. (We can probably work around this for the Construct Hub by using the JSON format instead).

Resolves #436

src/docgen/view/property.ts Outdated Show resolved Hide resolved
src/docgen/transpile/typescript.ts Outdated Show resolved Hide resolved
src/docgen/transpile/transpile.ts Outdated Show resolved Hide resolved
src/docgen/transpile/java.ts Outdated Show resolved Hide resolved
src/docgen/transpile/java.ts Outdated Show resolved Hide resolved
@Chriscbr Chriscbr requested a review from iliapolo September 13, 2021 16:34
src/docgen/view/property.ts Outdated Show resolved Hide resolved
@Chriscbr Chriscbr requested a review from iliapolo September 13, 2021 20:17
@mergify mergify bot merged commit 0722130 into master Sep 13, 2021
@mergify mergify bot deleted the rybickic/property-examples branch September 13, 2021 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show code declaration of properties
2 participants