Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing h2 heading to gcds-footer #145

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Conversation

ethanWallace
Copy link
Collaborator

Summary | Résumé

Flagged in cds-snc/gcds-docs#139. gcds-footer was missing an h2 heading at the start of the footer. Added the heading into the footer to solve the issue.

@ethanWallace ethanWallace requested a review from nmakuch April 17, 2023 17:45
Copy link
Contributor

@nmakuch nmakuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

@ethanWallace ethanWallace merged commit dde9f87 into main Apr 19, 2023
@ethanWallace ethanWallace deleted the footer-heading-fix branch April 19, 2023 14:32
@ethanWallace ethanWallace mentioned this pull request May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants