-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seal global cosmos config outside of the cli #1331
Comments
Nice! We did almost the same recently. The PR name, though does not reflect what was in the final form, but I moved this init to one place in |
@vgonkivs currently we are sealing here celestia-app/cmd/celestia-appd/cmd/root.go Lines 51 to 55 in 0b447ad
I haven't tried this, but we can probably just include that in an init function in the app package. either directly in this file, or in its own |
## Overview Closes #1331 ## Checklist <!-- Please complete the checklist to ensure that the PR is ready to be reviewed. IMPORTANT: PRs should be left in Draft until the below checklist is completed. --> - [x] New and updated code has appropriate documentation - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing - [x] Visual proof for any user facing features like CLI or documentation updates - [x] Linked issues closed with keywords
## Overview Closes celestiaorg/celestia-app#1331 ## Checklist <!-- Please complete the checklist to ensure that the PR is ready to be reviewed. IMPORTANT: PRs should be left in Draft until the below checklist is completed. --> - [x] New and updated code has appropriate documentation - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing - [x] Visual proof for any user facing features like CLI or documentation updates - [x] Linked issues closed with keywords
to avoid breaking all the tests and increase diff from upstream in this repo, I think we should attempt a different approach where we only call the config/seal functions once in the app in some init function, then import something from that file in celestia-node. I think that will force us to only seal a single time, instead of once in the cli for app and node each.
Originally posted by @evan-forbes in celestiaorg/cosmos-sdk#297 (review)
The text was updated successfully, but these errors were encountered: