Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: backport for rc7 #2024

Merged
merged 1 commit into from
Jul 4, 2023
Merged

chore!: backport for rc7 #2024

merged 1 commit into from
Jul 4, 2023

Conversation

evan-forbes
Copy link
Member

@evan-forbes evan-forbes commented Jul 4, 2023

Overview

backports the latest fix #2022 for rc7

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

consistently pass the correct chain-id to the application using
`RequestPrepareProposal` and `RequestProcessProposal`

this PR still needs to update the go.mod to use the official tag of
tendermint after its released

closes #2020 and #2021

- [x] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [x] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords
@evan-forbes evan-forbes requested a review from rootulp as a code owner July 4, 2023 14:11
@evan-forbes evan-forbes self-assigned this Jul 4, 2023
@MSevey MSevey requested a review from a team July 4, 2023 14:12
@evan-forbes evan-forbes merged commit 2ad80bc into v1.x Jul 4, 2023
@evan-forbes evan-forbes deleted the evan/backport-for-rc7 branch July 4, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants