Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix godoc for RequestPrepareProposal #1029

Closed
evan-forbes opened this issue Jul 4, 2023 · 0 comments · Fixed by #1034
Closed

Fix godoc for RequestPrepareProposal #1029

evan-forbes opened this issue Jul 4, 2023 · 0 comments · Fixed by #1034
Assignees
@rootulp

Comments

@evan-forbes
Copy link
Member 

          [question] is this godoc copied from somewhere? If not, proposal to make the godoc reference the field name b/c I'm not sure what the relationship is between `proposal_header` and `chain_id` but they seem distinct. 

  // chain_id is a unique identifier for the blockchain network this proposal belongs to (e.g. mocha-1)

Originally posted by @rootulp in #1028 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: fix godoc for chain_id rootulp/celestia-core
2 participants
@rootulp @evan-forbes