Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(share/discovery): Ensure only one discovery process running. #1613

Closed
walldiss opened this issue Jan 18, 2023 · 0 comments · Fixed by #1642
Closed

feat(share/discovery): Ensure only one discovery process running. #1613

walldiss opened this issue Jan 18, 2023 · 0 comments · Fixed by #1642
Assignees
@walldiss
Labels
area:shares Shares and samples

Comments

@walldiss
Copy link
Member

Implementation ideas

Current Discovery API provides only direct run of EnsurePeers . With this approach multiple Discovery clients will need spawn its own run go-routines. The process of discovery could be done with only one running discovery cycle routine, so this API needs to be improved. Ensure that there is max 1 instance of discovery EnsurePeers loop running.
@walldiss walldiss self-assigned this Jan 18, 2023
@walldiss walldiss moved this from TODO to In Progress in Celestia Node Jan 18, 2023
@walldiss walldiss mentioned this issue Jan 26, 2023
Merged
5 tasks
@walldiss walldiss moved this from In Progress to In Review in Celestia Node Jan 26, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Celestia Node Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@walldiss walldiss

Labels
area:shares Shares and samples
Projects
No open projects
Celestia Node
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(share/discovery): Ensure only one instance of EnsurePeers is running walldiss/celestia-node
1 participant
@walldiss