-
Notifications
You must be signed in to change notification settings - Fork 931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit test for CoreAccess
#570
Labels
area:core_and_app
Relationship with Core node and Celestia-App
area:state
Related to fetching state and state execution
kind:testing
Related to unit tests
Comments
7 tasks
renaynay
changed the title
Add unit test for
Add unit test for Mar 30, 2022
CoreAccess
once mock celestia-app issueCoreAccess
once mock celestia-app issue is fixed
renaynay
added
area:state
Related to fetching state and state execution
area:core_and_app
Relationship with Core node and Celestia-App
labels
Mar 30, 2022
6 tasks
renaynay
added a commit
to renaynay/celestia-node
that referenced
this issue
Mar 30, 2022
renaynay
added a commit
to renaynay/celestia-node
that referenced
this issue
Mar 30, 2022
renaynay
added a commit
that referenced
this issue
Mar 30, 2022
…nt `CoreAccess` (#420) * CoreAccessor * update ADR with changes made to CoreAccess design * cleanup * use new insecure.NewCredentials w grpc cli * keyconf documentation * add doc.go * document service struct * remove unnecessary type aliases * add lifecycle hooks * test: failing due to cel-app panic with InitChain * chore|refactor: go mod tidy & change grpc dial to DialContext * fix: add watchdog dep * chore: lint * refactor: dont return err with constructor * docs: update state ADR to remove mentions of lens * fix: remove unused encCfg field from CoreAccess * refactor: remove KeyConfig and use "default" as KeyringAccName by default * chore: mod tidy * refactor: setup queryClient in Start of CoreAccess * docs: fix typo in lightComponents doc * comment out test * chore: lint * bug: grpc needs insecure credentials * refactor: BalanceForAddress takes types.AccAddress instead of string, state access available on full node too * refactor: use BroadcastMode_BROADCAST_MODE_BLOCK as default for tx submission * feat: add SubmitTxWithBroadcastMode but dont add to StateAccessor interface for now * refactor: pass keystore to constructor instead of string to path and implement Path method in Keystore | lint * chore: update celestia-core dep to prevent weird lint error * refactor: add state serv to baseComponents * refactor: BalanceForAddress takes a types.Address from cosmos sdk instead of types.AccAddress * doc: fix typo Co-authored-by: Hlib Kanunnikov <hlibwondertan@gmail.com> * test: delete unit test for core access as it doesnt work in favour of #570 * refactor: add params.Network after rebase Co-authored-by: Hlib Kanunnikov <hlibwondertan@gmail.com>
2 tasks
nashqueue
pushed a commit
to celestiaorg/go-header
that referenced
this issue
Sep 29, 2022
…nt `CoreAccess` (#420) * CoreAccessor * update ADR with changes made to CoreAccess design * cleanup * use new insecure.NewCredentials w grpc cli * keyconf documentation * add doc.go * document service struct * remove unnecessary type aliases * add lifecycle hooks * test: failing due to cel-app panic with InitChain * chore|refactor: go mod tidy & change grpc dial to DialContext * fix: add watchdog dep * chore: lint * refactor: dont return err with constructor * docs: update state ADR to remove mentions of lens * fix: remove unused encCfg field from CoreAccess * refactor: remove KeyConfig and use "default" as KeyringAccName by default * chore: mod tidy * refactor: setup queryClient in Start of CoreAccess * docs: fix typo in lightComponents doc * comment out test * chore: lint * bug: grpc needs insecure credentials * refactor: BalanceForAddress takes types.AccAddress instead of string, state access available on full node too * refactor: use BroadcastMode_BROADCAST_MODE_BLOCK as default for tx submission * feat: add SubmitTxWithBroadcastMode but dont add to StateAccessor interface for now * refactor: pass keystore to constructor instead of string to path and implement Path method in Keystore | lint * chore: update celestia-core dep to prevent weird lint error * refactor: add state serv to baseComponents * refactor: BalanceForAddress takes a types.Address from cosmos sdk instead of types.AccAddress * doc: fix typo Co-authored-by: Hlib Kanunnikov <hlibwondertan@gmail.com> * test: delete unit test for core access as it doesnt work in favour of celestiaorg/celestia-node#570 * refactor: add params.Network after rebase Co-authored-by: Hlib Kanunnikov <hlibwondertan@gmail.com>
We now have App test suit, so we can cover all state endpoints now. Also, they will be covered by #2337. However, this won't be a unit test and we should write unit tests without any integration test suite |
Wondertan
changed the title
Add unit test for
Add unit test for Jun 12, 2023
CoreAccess
once mock celestia-app issue is fixedCoreAccess
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:core_and_app
Relationship with Core node and Celestia-App
area:state
Related to fetching state and state execution
kind:testing
Related to unit tests
TODO link to tracking issue for mock celestia-app blocker
The text was updated successfully, but these errors were encountered: