Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(swamp): replace cosmos prefix with celestia in swamp tests #1583

Merged

Conversation

vgonkivs
Copy link
Member

@vgonkivs vgonkivs commented Jan 10, 2023

Overview

Use "celestia" prefix for accounts instead of "cosmos" in swamp tests

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@vgonkivs vgonkivs added swamp Related to Integration tests kind:fix Attached to bug-fixing PRs labels Jan 10, 2023
@vgonkivs vgonkivs self-assigned this Jan 10, 2023
@vgonkivs vgonkivs changed the title chore: replace cosmos prefix with celestia in swamp tests chore(swamp): replace cosmos prefix with celestia in swamp tests Jan 10, 2023
@vgonkivs vgonkivs force-pushed the add_celestia_prefix_in_swamp_tests branch from 4ebec2c to c9f9685 Compare January 10, 2023 15:36
@Wondertan
Copy link
Member

Wondertan commented Jan 10, 2023

Does it fixes tests on mac? Also the question why did it work before

nodebuilder/tests/swamp/swamp.go Outdated Show resolved Hide resolved
@vgonkivs vgonkivs marked this pull request as draft January 11, 2023 12:13
@vgonkivs vgonkivs force-pushed the add_celestia_prefix_in_swamp_tests branch from c9f9685 to 86a56fa Compare January 24, 2023 13:16
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2023

Codecov Report

Merging #1583 (ced5107) into main (311d9dc) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1583      +/-   ##
==========================================
- Coverage   54.91%   54.89%   -0.02%     
==========================================
  Files         230      231       +1     
  Lines       14983    14995      +12     
==========================================
+ Hits         8228     8232       +4     
- Misses       5874     5882       +8     
  Partials      881      881              
Impacted Files Coverage Δ
cmd/celestia/main.go 47.05% <ø> (-15.45%) ⬇️
core/config.go 100.00% <100.00%> (ø)
state/core_access.go 28.04% <0.00%> (-0.86%) ⬇️
core/testing.go 84.50% <0.00%> (+0.44%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vgonkivs vgonkivs marked this pull request as ready for review January 24, 2023 13:55
@vgonkivs vgonkivs requested a review from Wondertan January 24, 2023 13:55
distractedm1nd
distractedm1nd previously approved these changes Jan 24, 2023
renaynay
renaynay previously approved these changes Jan 24, 2023
core/fetcher.go Outdated Show resolved Hide resolved
@vgonkivs vgonkivs dismissed stale reviews from renaynay and distractedm1nd via ced5107 January 24, 2023 15:16
@vgonkivs vgonkivs force-pushed the add_celestia_prefix_in_swamp_tests branch from ced5107 to 2b22508 Compare January 24, 2023 15:45
@vgonkivs vgonkivs merged commit f3b334f into celestiaorg:main Jan 25, 2023
derrandz added a commit to derrandz/celestia-node that referenced this pull request Jan 26, 2023
Bidon15 added a commit to Bidon15/celestia-node that referenced this pull request Jan 26, 2023
walldiss pushed a commit to walldiss/celestia-node that referenced this pull request Jan 26, 2023
distractedm1nd pushed a commit to distractedm1nd/celestia-node that referenced this pull request Jan 26, 2023
derrandz added a commit to derrandz/celestia-node that referenced this pull request Jan 27, 2023
Bidon15 added a commit to Bidon15/celestia-node that referenced this pull request Jan 27, 2023
derrandz added a commit to derrandz/celestia-node that referenced this pull request Jan 27, 2023
derrandz added a commit to derrandz/celestia-node that referenced this pull request Jan 27, 2023
renaynay pushed a commit to renaynay/celestia-node that referenced this pull request Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:fix Attached to bug-fixing PRs swamp Related to Integration tests
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants