feat(share/discovery): Add callback on peers set updates. #1609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walldiss
force-pushed
the
discovery_on_peers_update
branch
from
a61c997 to
75e05ea
Compare
walldiss
force-pushed
the
discovery_on_peers_update
branch
4 times, most recently
from
fc2ca14 to
586ea49
Compare
walldiss
requested review from
renaynay,
Wondertan,
vgonkivs and
distractedm1nd
as code owners
Wondertan
changed the title
Wondertan
previously approved these changes
Jan 17, 2023
distractedm1nd
suggested changes
Jan 17, 2023
There was a problem hiding this comment.
One question: why send all peers through onPeersUpdate since it's called in handlePeerFound? Can't we just name it onPeerFound/OnPeerFound and only send in the new peer? And I agree with hlib that it might be better with a channel, if you agree (but really optional)
Also needs a test
vgonkivs
reviewed
Jan 17, 2023
vgonkivs
reviewed
Jan 18, 2023
walldiss
force-pushed
the
discovery_on_peers_update
branch
from
33c6d5e to
986a21f
Compare
|
Updated with @distractedm1nd suggestion to only emit diff, not the full peers list. This removes some changes in set.go and in tests. As a note: callback provider will needs to be careful with keeping state up to date so it don't diverge from discovery one. |
distractedm1nd
suggested changes
Jan 18, 2023
Wondertan
approved these changes
Jan 18, 2023
vgonkivs
approved these changes
Jan 20, 2023
Co-authored-by: Ryan <ryan@celestia.org>
walldiss
force-pushed
the
discovery_on_peers_update
branch
from
c0722c9 to
02ae2df
Compare
jpserrat
pushed a commit
to jpserrat/celestia-node
that referenced
this pull request
Jan 23, 2023
…g#1609) notify Discovery clients about peers set changes in async manner by calling provided callback. Co-authored-by: Ryan <ryan@celestia.org>
distractedm1nd
added a commit
to distractedm1nd/celestia-node
that referenced
this pull request
Jan 26, 2023
…g#1609) notify Discovery clients about peers set changes in async manner by calling provided callback. Co-authored-by: Ryan <ryan@celestia.org>
renaynay
pushed a commit
to renaynay/celestia-node
that referenced
this pull request
Jan 31, 2023
…g#1609) notify Discovery clients about peers set changes in async manner by calling provided callback. Co-authored-by: Ryan <ryan@celestia.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Notify Discovery clients about peers set changes in async manner by calling provided callback.
(ps *limitedSet)Peersmethod splitted into two funcs:ListPeersandWaitPeer, so callback is not locked in case there are no peers.Closes #1610
Checklist