Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub CI check for Markdownlint #948

Merged
merged 9 commits into from
Jul 28, 2022

Conversation

rootulp
Copy link
Contributor

@rootulp rootulp commented Jul 26, 2022

Resolves #947

.markdownlintrc Outdated Show resolved Hide resolved
.markdownlintrc Outdated Show resolved Hide resolved
docs/adr/adr-006-fraud-service.md Show resolved Hide resolved
extensions.json Outdated Show resolved Hide resolved
@rootulp rootulp self-assigned this Jul 26, 2022
@rootulp rootulp marked this pull request as ready for review July 26, 2022 18:39
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2022

Codecov Report

Merging #948 (345c7aa) into main (718f364) will increase coverage by 0.24%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #948      +/-   ##
==========================================
+ Coverage   58.26%   58.50%   +0.24%     
==========================================
  Files         129      129              
  Lines        7727     7727              
==========================================
+ Hits         4502     4521      +19     
+ Misses       2754     2735      -19     
  Partials      471      471              
Impacted Files Coverage Δ
fraud/pb/proof.pb.go 33.51% <0.00%> (+4.28%) ⬆️
header/core/listener.go 58.49% <0.00%> (+5.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@rootulp rootulp requested a review from adlerjohn July 26, 2022 21:38
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks for this

Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one rebase pls @rootulp 🙏🏻

renaynay and others added 3 commits July 27, 2022 10:20
…stiaorg#911)

* refactor: extract HeaderGetter interface from daser into header pkg

* refactor: delete interface.go file from das pkg

* refactor: Store interface wraps getter methods

* chore: rebase fixes

* feat: add `/verified_balance` endpoint

* chore: lint

* refactor: dedup handleBalanceRequest

* docs: update state ADR

* refactor: consolidate verified_balance and balance endpoints --> verify balance by default

* chore: replace TODOs with PR refs

* refactor: apply john review comments

* refactor: extract sdk error func into helpers file, rename import aliases

* doc: update ADR header.Store -> header.Getter
@rootulp
Copy link
Contributor Author

rootulp commented Jul 27, 2022

@Wondertan @renaynay this PR is ready to be merged.

May I request write access to this repo so that I can merge it / future approved PRs?

Screen Shot 2022-07-27 at 11 41 09 AM

@renaynay renaynay merged commit f45cf1d into celestiaorg:main Jul 28, 2022
@rootulp rootulp deleted the rp/markdownlint-ci branch July 28, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: Lint Markdown files
5 participants