New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test operators used by celestia-core #332

Open

rootulp opened this issue Jul 14, 2023 · 0 comments

Collaborator

rootulp commented Jul 14, 2023

[Non blocking][Question]
Does it make sense to add tests also for the other operators supported by core?

https://github.com/celestiaorg/celestia-core/blob/3e636bb02f48cc02b11f4aea3dd1494ef8e62c91/libs/pubsub/query/query.go#L65-L84

Even if they're caught by the regex, so that upcoming changes don't end up breaking the API again

Originally posted by @sweexordious in #331 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment