-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: arabica upgrade height #1666
Conversation
WalkthroughThe recent changes enhance the documentation for the Celestia network's upgrade process, particularly focusing on the Lemongrass hardfork. Key modifications include specifying exact versions for the Changes
Possibly related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving for when it's ready to smorge
FYI we likely need to push this date and upgrade height back b/c Arabica validators haven't upgraded yet. |
Pushing this upgrade height back to Monday one week from today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
nodes/hardfork-process.md (1)
43-44
: Consider using a more concise wording.The phrase "prior to" can be replaced with "before" for improved clarity and conciseness.
- and run a celestia-app binary >= v2.0.0 prior to the `--v2-upgrade-height` to remain on the canonical chain. + and run a celestia-app binary >= v2.0.0 before the `--v2-upgrade-height` to remain on the canonical chain.- you will need to download and run a compatible celestia-node binary >= v0.16.0-rc0 prior to the upgrade height. + you will need to download and run a compatible celestia-node binary >= v0.16.0-rc0 before the upgrade height.Tools
LanguageTool
[style] ~43-~43: ‘prior to’ might be wordy. Consider a shorter alternative.
Context: ...and run a celestia-app binary >= v2.0.0 prior to the--v2-upgrade-height
to remain on ...(EN_WORDINESS_PREMIUM_PRIOR_TO)
[style] ~44-~44: ‘prior to’ might be wordy. Consider a shorter alternative.
Context: ...ble celestia-node binary >= v0.16.0-rc0 prior to the upgrade height. Network | Cha...(EN_WORDINESS_PREMIUM_PRIOR_TO)
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- nodes/consensus-node.md (1 hunks)
- nodes/hardfork-process.md (1 hunks)
- nodes/validator-node.md (1 hunks)
Additional context used
LanguageTool
nodes/hardfork-process.md
[style] ~43-~43: ‘prior to’ might be wordy. Consider a shorter alternative.
Context: ...and run a celestia-app binary >= v2.0.0 prior to the--v2-upgrade-height
to remain on ...(EN_WORDINESS_PREMIUM_PRIOR_TO)
[style] ~44-~44: ‘prior to’ might be wordy. Consider a shorter alternative.
Context: ...ble celestia-node binary >= v0.16.0-rc0 prior to the upgrade height. Network | Cha...(EN_WORDINESS_PREMIUM_PRIOR_TO)
Additional comments not posted (3)
nodes/hardfork-process.md (1)
46-50
: Table format and content are clear and accurate.The table provides a clear overview of the upgrade details for the networks. Ensure that the information is kept up-to-date as changes occur.
nodes/validator-node.md (1)
164-164
: Upgrade height specification is clear and accurate.Replacing the placeholder with a specific value ensures clarity for node operators. Ensure that this value is coordinated with the DevOps team and updated if necessary.
nodes/consensus-node.md (1)
314-314
: Upgrade height specification is clear and accurate.Replacing the placeholder with a specific value ensures clarity for node operators. Ensure that this value is coordinated with the DevOps team and updated if necessary.
Draft PR. We should coordinate this value with DevOps and @tty47 before merging.
Note the value was sourced from celestiaorg/celestia-app#3761
Summary by CodeRabbit
New Features
Documentation
celestia-app
andcelestia-node
binaries.