-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: increase precision of TIA Allocation at Genesis #1699
Conversation
WalkthroughThe changes involve formatting and content adjustments in the Changes
Sequence Diagram(s)(No diagrams generated as the changes are primarily cosmetic and do not involve new features or control flow modifications.) Poem
Tip Announcements
Recent review detailsConfiguration used: CodeRabbit UI Files ignored due to path filters (1)
Files selected for processing (1)
Additional context usedLanguageTool
Additional comments not posted (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- learn/staking-governance-supply.md (3 hunks)
Files skipped from review due to trivial changes (1)
- learn/staking-governance-supply.md
Moving to draft until we confirm the spreadsheet that these changes are based on is correct. |
learn/staking-governance-supply.md
Outdated
| R&D & Ecosystem | Tokens allocated to the Celestia Foundation and core devs for research, development, and ecosystem initiatives including:<br/>- Protocol maintenance and development<br/>- Programs for rollup developers, infrastructure, and node operators | 26.87% | | ||
| Early Backers: Series A&B | Early supporters of Celestia | 19.67% | | ||
| Early Backers: Seed | Early supporters of Celestia | 15.90% | | ||
| Initial Core Contributors | Members of Celestia Labs, the first core contributor to Celestia | 17.56% | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, adds up to 100%
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
requesting changes as need to ask Alina for diagram once final #s are set
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
public/img/learn/Celestia_TIA_Allocation_at_Genesis.png
is excluded by!**/*.png
Files selected for processing (1)
- learn/staking-governance-supply.md (3 hunks)
Additional context used
LanguageTool
learn/staking-governance-supply.md
[uncategorized] ~109-~109: The preposition “in” seems more likely in this position than the preposition “at”.
Context: ...y Backers: Seed | 33.33% unlocked at year 1.
Remaining 66.67% unlocks co...(AI_EN_LECTOR_REPLACEMENT_PREPOSITION_AT_IN)
[uncategorized] ~110-~110: The preposition “in” seems more likely in this position than the preposition “at”.
Context: ...y Backers: Series A&B | 33.33% unlocked at year 1.
Remaining 66.67% unlocks co...(AI_EN_LECTOR_REPLACEMENT_PREPOSITION_AT_IN)
Additional comments not posted (1)
learn/staking-governance-supply.md (1)
75-81
: Enhanced precision in TIA allocation table.The changes to the TIA allocation table, specifically the addition of decimal places to the percentage values, enhance the precision and clarity of the documentation. This aligns with the PR's objective to provide more accurate information regarding the allocation of tokens at the genesis block.
The formatting changes, such as the alignment and spacing adjustments, contribute to a cleaner presentation and improved readability. These changes are beneficial and should be maintained.
| Category | Unlock Schedule | | ||
|---------------------------|---------------------------------------------------------------------------------------------| | ||
| Public Allocation | Fully unlocked at launch. | | ||
| R&D & Ecosystem | 25.00% unlocked at launch.<br/>Remaining 75.00% unlocks continuously from year 1 to year 4. | | ||
| Initial Core Contributors | 33.33% unlocked at year 1.<br/>Remaining 66.67% unlocks continuously from year 1 to year 3. | | ||
| Early Backers: Seed | 33.33% unlocked at year 1.<br/>Remaining 66.67% unlocks continuously from year 1 to year 2. | | ||
| Early Backers: Series A&B | 33.33% unlocked at year 1.<br/>Remaining 66.67% unlocks continuously from year 1 to year 2. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unlock schedule table updates are clear and informative.
The updates to the unlock schedule table are clear and provide detailed information about the unlocking of tokens across different categories. This is crucial for understanding the distribution and availability of tokens over time.
However, there are minor grammatical suggestions from the static analysis tool regarding the preposition used in the unlock schedule descriptions for "Early Backers: Seed" and "Early Backers: Series A&B". It suggests using "in" instead of "at" for better grammatical accuracy.
Consider applying these grammatical corrections:
- 33.33% unlocked at year 1.<br/>Remaining 66.67% unlocks continuously from year 1 to year 2.
+ 33.33% unlocked in year 1.<br/>Remaining 66.67% unlocks continuously from year 1 to year 2.
- 33.33% unlocked at year 1.<br/>Remaining 66.67% unlocks continuously from year 1 to year 2.
+ 33.33% unlocked in year 1.<br/>Remaining 66.67% unlocks continuously from year 1 to year 2.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| Category | Unlock Schedule | | |
|---------------------------|---------------------------------------------------------------------------------------------| | |
| Public Allocation | Fully unlocked at launch. | | |
| R&D & Ecosystem | 25.00% unlocked at launch.<br/>Remaining 75.00% unlocks continuously from year 1 to year 4. | | |
| Initial Core Contributors | 33.33% unlocked at year 1.<br/>Remaining 66.67% unlocks continuously from year 1 to year 3. | | |
| Early Backers: Seed | 33.33% unlocked at year 1.<br/>Remaining 66.67% unlocks continuously from year 1 to year 2. | | |
| Early Backers: Series A&B | 33.33% unlocked at year 1.<br/>Remaining 66.67% unlocks continuously from year 1 to year 2. | | |
| Category | Unlock Schedule | | |
|---------------------------|---------------------------------------------------------------------------------------------| | |
| Public Allocation | Fully unlocked at launch. | | |
| R&D & Ecosystem | 25.00% unlocked at launch.<br/>Remaining 75.00% unlocks continuously from year 1 to year 4. | | |
| Initial Core Contributors | 33.33% unlocked at year 1.<br/>Remaining 66.67% unlocks continuously from year 1 to year 3. | | |
| Early Backers: Seed | 33.33% unlocked in year 1.<br/>Remaining 66.67% unlocks continuously from year 1 to year 2. | | |
| Early Backers: Series A&B | 33.33% unlocked in year 1.<br/>Remaining 66.67% unlocks continuously from year 1 to year 2. | |
Tools
LanguageTool
[uncategorized] ~109-~109: The preposition “in” seems more likely in this position than the preposition “at”.
Context: ...y Backers: Seed | 33.33% unlocked at year 1.
Remaining 66.67% unlocks co...(AI_EN_LECTOR_REPLACEMENT_PREPOSITION_AT_IN)
[uncategorized] ~110-~110: The preposition “in” seems more likely in this position than the preposition “at”.
Context: ...y Backers: Series A&B | 33.33% unlocked at year 1.
Remaining 66.67% unlocks co...(AI_EN_LECTOR_REPLACEMENT_PREPOSITION_AT_IN)
Increase precision of the table under TIA Allocation at Genesis. Also updates the graphic, thanks Alina!
Summary by CodeRabbit
staking-governance-supply
document by adjusting numerical values in tables to two decimal places.