-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: use breaking network upgrade
for lemongrass
#1716
Conversation
WalkthroughThe pull request introduces a critical update across several documentation files, changing the terminology from "Lemongrass network upgrade" to "Lemongrass breaking network upgrade." This adjustment clarifies that the upgrade includes breaking changes, which is essential for users to understand potential impacts on compatibility and functionality. Changes
Possibly related issues
Possibly related PRs
Suggested labels
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
nodes/network-upgrade-process.md (1)
41-43
: LGTM: The section title change accurately reflects the nature of the upgrade.The content of the section provides clear and detailed information about the upgrade process.
Consider the following minor style improvements:
-The Lemongrass breaking network upgrade includes all of the CIPs listed in [CIP-17](https://github.com/celestiaorg/CIPs/blob/main/cips/cip-17.md). +The Lemongrass breaking network upgrade includes all the CIPs listed in [CIP-17](https://github.com/celestiaorg/CIPs/blob/main/cips/cip-17.md). -If you are a consensus node or validator operator: you will need to download and run a celestia-app binary >= v2.0.0 prior to the `--v2-upgrade-height` to remain on the canonical chain. +If you are a consensus node or validator operator: you will need to download and run a celestia-app binary >= v2.0.0 before the `--v2-upgrade-height` to remain on the canonical chain.Tools
LanguageTool
[style] ~43-~43: Consider removing “of” to be more concise
Context: ...grass breaking network upgrade includes all of the CIPs listed in [CIP-17](https://github....(ALL_OF_THE)
[style] ~43-~43: ‘prior to’ might be wordy. Consider a shorter alternative.
Context: ... download and start a compatible binary prior to the upgrade height. - If you are a con...(EN_WORDINESS_PREMIUM_PRIOR_TO)
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- nodes/arabica-devnet.md (1 hunks)
- nodes/mainnet.md (1 hunks)
- nodes/mocha-testnet.md (1 hunks)
- nodes/network-upgrade-process.md (1 hunks)
- nodes/participate.md (1 hunks)
Files skipped from review due to trivial changes (4)
- nodes/arabica-devnet.md
- nodes/mainnet.md
- nodes/mocha-testnet.md
- nodes/participate.md
Additional context used
LanguageTool
nodes/network-upgrade-process.md
[style] ~43-~43: Consider removing “of” to be more concise
Context: ...grass breaking network upgrade includes all of the CIPs listed in [CIP-17](https://github....(ALL_OF_THE)
[style] ~43-~43: ‘prior to’ might be wordy. Consider a shorter alternative.
Context: ... download and start a compatible binary prior to the upgrade height. - If you are a con...(EN_WORDINESS_PREMIUM_PRIOR_TO)
Closing this to move forward with "hardfork" -> "network upgrade" because there was no mention of "softfork" or "non-breaking network upgrade" in either CIP docs or in Celestia docs. |
Overview
Clarifies "breaking network upgrade" based on:
Summary by CodeRabbit
New Features
Documentation