-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update noders archive RPC in mainnet.md #1732
Conversation
Changed port
WalkthroughThe pull request introduces a modification to the RPC port configuration for the Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -282,7 +282,7 @@ RPCs for DA nodes to initialise or start your celestia-node to Mainnet Beta with | |||
- RPC: 28657 | |||
- `celestia-consensus-mainnet.noders.services` | |||
- gRPC: port 9080 | |||
- RPC: port 26557 | |||
- RPC: port 26657 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Action Required: Update RPC Port References for celestia-consensus-mainnet.noders.services
.
The RPC port for celestia-consensus-mainnet.noders.services
has been updated to 26657
, but there are instances where the endpoint is mentioned without specifying the port. Please ensure that all references to this endpoint include the updated port to maintain consistency and prevent potential connectivity issues.
- File:
nodes/mainnet.md
🔗 Analysis chain
LGTM. Verify consistency across documentation.
The update of the RPC port for celestia-consensus-mainnet.noders.services
from 26557 to 26657 is correct. This aligns with the common default port for Tendermint RPC used by Celestia.
To ensure consistency, please run the following script to check if this endpoint is mentioned elsewhere in the documentation:
This will help identify any other instances where this endpoint is mentioned, ensuring all references are updated consistently.
Please run the following corrected script to verify the consistency of the RPC port across the documentation:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Search for mentions of the noders.services endpoint across all Markdown files
# Search for the old port
echo "Searching for old port (26557):"
rg --type md "celestia-consensus-mainnet\.noders\.services.*26557"
# Search for the new port
echo "Searching for new port (26657):"
rg --type md "celestia-consensus-mainnet\.noders\.services.*26657"
# Search for any mention of the endpoint without specifying the port
echo "Searching for endpoint without port specification:"
rg --type md "celestia-consensus-mainnet\.noders\.services" -v "26[56]57"
Length of output: 519
Script:
#!/bin/bash
# Description: Search for mentions of the noders.services endpoint across all Markdown files
# Search for the old port
echo "Searching for old port (26557):"
rg --type md "celestia-consensus-mainnet\.noders\.services.*26557"
# Search for the new port
echo "Searching for new port (26657):"
rg --type md "celestia-consensus-mainnet\.noders\.services.*26657"
# Search for any mention of the endpoint without specifying the port
echo "Searching for endpoint without port specification:"
rg --type md "celestia-consensus-mainnet\.noders\.services" | rg -v "26[56]57"
Length of output: 539
Changed port
Overview
Summary by CodeRabbit
New Features
Bug Fixes