Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update noders archive RPC in mainnet.md #1732

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Conversation

nodersteam
Copy link
Contributor

@nodersteam nodersteam commented Sep 26, 2024

Changed port

Overview

Summary by CodeRabbit

  • New Features

    • Updated RPC port configuration for improved connectivity to the Mainnet Beta.
  • Bug Fixes

    • Addressed potential connectivity issues for DA full and light nodes.

Copy link
Contributor

coderabbitai bot commented Sep 26, 2024

Walkthrough

The pull request introduces a modification to the RPC port configuration for the celestia-consensus-mainnet.noders.services. The RPC port has been updated from 26557 to 26657, which affects the initialization and startup process of the celestia-node for Mainnet Beta. This change may lead to connectivity issues for DA full and light nodes, though no additional functionality or logic changes are included in this update.

Changes

File Path Change Summary
nodes/mainnet.md RPC port updated from 26557 to 26657 in celestia-consensus-mainnet.noders.services

Possibly related PRs

  • add NODERS info  #1635: This PR introduces the celestia-consensus-mainnet.noders.services with an RPC port of 26557, which is directly related to the RPC port change from 26557 to 26657 in the main PR.

Poem

In the land of code where rabbits hop,
A port was changed, oh what a swap!
From 26557 to 26657 it flew,
Connecting nodes, both old and new.
With a twitch of a nose and a leap of delight,
We celebrate changes that feel just right! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 7a373e5 and b26f7b8.

📒 Files selected for processing (1)
  • nodes/mainnet.md (1 hunks)

@@ -282,7 +282,7 @@ RPCs for DA nodes to initialise or start your celestia-node to Mainnet Beta with
- RPC: 28657
- `celestia-consensus-mainnet.noders.services`
- gRPC: port 9080
- RPC: port 26557
- RPC: port 26657
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Action Required: Update RPC Port References for celestia-consensus-mainnet.noders.services.

The RPC port for celestia-consensus-mainnet.noders.services has been updated to 26657, but there are instances where the endpoint is mentioned without specifying the port. Please ensure that all references to this endpoint include the updated port to maintain consistency and prevent potential connectivity issues.

  • File: nodes/mainnet.md
🔗 Analysis chain

LGTM. Verify consistency across documentation.

The update of the RPC port for celestia-consensus-mainnet.noders.services from 26557 to 26657 is correct. This aligns with the common default port for Tendermint RPC used by Celestia.

To ensure consistency, please run the following script to check if this endpoint is mentioned elsewhere in the documentation:

This will help identify any other instances where this endpoint is mentioned, ensuring all references are updated consistently.


Please run the following corrected script to verify the consistency of the RPC port across the documentation:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Search for mentions of the noders.services endpoint across all Markdown files

# Search for the old port
echo "Searching for old port (26557):"
rg --type md "celestia-consensus-mainnet\.noders\.services.*26557"

# Search for the new port
echo "Searching for new port (26657):"
rg --type md "celestia-consensus-mainnet\.noders\.services.*26657"

# Search for any mention of the endpoint without specifying the port
echo "Searching for endpoint without port specification:"
rg --type md "celestia-consensus-mainnet\.noders\.services" -v "26[56]57"

Length of output: 519


Script:

#!/bin/bash
# Description: Search for mentions of the noders.services endpoint across all Markdown files

# Search for the old port
echo "Searching for old port (26557):"
rg --type md "celestia-consensus-mainnet\.noders\.services.*26557"

# Search for the new port
echo "Searching for new port (26657):"
rg --type md "celestia-consensus-mainnet\.noders\.services.*26657"

# Search for any mention of the endpoint without specifying the port
echo "Searching for endpoint without port specification:"
rg --type md "celestia-consensus-mainnet\.noders\.services" | rg -v "26[56]57"

Length of output: 539

@jcstein jcstein merged commit 716ebb3 into celestiaorg:main Sep 26, 2024
2 of 3 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Oct 24, 2024
@coderabbitai coderabbitai bot mentioned this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants