Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update noders archive RPC in mainnet.md #1732

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Update noders archive RPC in mainnet.md #1732

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nodes/mainnet.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ RPCs for DA nodes to initialise or start your celestia-node to Mainnet Beta with
- RPC: 28657
- `celestia-consensus-mainnet.noders.services`
- gRPC: port 9080
- RPC: port 26557
- RPC: port 26657
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Action Required: Update RPC Port References for celestia-consensus-mainnet.noders.services.

The RPC port for celestia-consensus-mainnet.noders.services has been updated to 26657, but there are instances where the endpoint is mentioned without specifying the port. Please ensure that all references to this endpoint include the updated port to maintain consistency and prevent potential connectivity issues.

  • File: nodes/mainnet.md
🔗 Analysis chain

LGTM. Verify consistency across documentation.

The update of the RPC port for celestia-consensus-mainnet.noders.services from 26557 to 26657 is correct. This aligns with the common default port for Tendermint RPC used by Celestia.

To ensure consistency, please run the following script to check if this endpoint is mentioned elsewhere in the documentation:

This will help identify any other instances where this endpoint is mentioned, ensuring all references are updated consistently.

Please run the following corrected script to verify the consistency of the RPC port across the documentation:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Search for mentions of the noders.services endpoint across all Markdown files

# Search for the old port
echo "Searching for old port (26557):"
rg --type md "celestia-consensus-mainnet\.noders\.services.*26557"

# Search for the new port
echo "Searching for new port (26657):"
rg --type md "celestia-consensus-mainnet\.noders\.services.*26657"

# Search for any mention of the endpoint without specifying the port
echo "Searching for endpoint without port specification:"
rg --type md "celestia-consensus-mainnet\.noders\.services" -v "26[56]57"

Length of output: 519

Script:

#!/bin/bash
# Description: Search for mentions of the noders.services endpoint across all Markdown files

# Search for the old port
echo "Searching for old port (26557):"
rg --type md "celestia-consensus-mainnet\.noders\.services.*26557"

# Search for the new port
echo "Searching for new port (26657):"
rg --type md "celestia-consensus-mainnet\.noders\.services.*26657"

# Search for any mention of the endpoint without specifying the port
echo "Searching for endpoint without port specification:"
rg --type md "celestia-consensus-mainnet\.noders\.services" | rg -v "26[56]57"

Length of output: 539


DA full and light nodes might have troubles connecting to the networks, so you
can check out this
Expand Down
Loading