Add WebSocket endpoints Cumulo #1741
Conversation
WalkthroughThe documentation for Celestia’s Mainnet Beta has been revised to provide comprehensive details on network stability, upgrades, and parameters. It clarifies that while the network is stable, it is still experimental. Enhancements include expanded information on transaction limits, a list of production RPC endpoints, and updates on community data availability nodes. Additional resources for network tracking and communication channels for updates have also been included. Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
nodes/mainnet.md (1)
224-224: LGTM! Consider minor formatting adjustment for consistency.The addition of the Cumulo WebSocket endpoint is appropriate and aligns with the PR objectives. The endpoint uses a secure WebSocket connection (
wss://), which is suitable for production use.For consistency with other entries in the list, consider removing the trailing slash from the URL:
- `wss://celestia.cumulo.org.es:443/websocket` + `wss://celestia.cumulo.org.es:443/websocket`
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- nodes/mainnet.md (1 hunks)
🔇 Additional comments (2)
nodes/mainnet.md (2)
Line range hint
301-303: LGTM! Cumulo endpoints added successfully.The addition of Cumulo's RPC and gRPC endpoints is consistent with the PR objectives and follows the established format. The use of standard ports (9090 for gRPC and 26657 for RPC) is correct for Celestia nodes.
Line range hint
1-352: Overall, the changes look good and achieve the PR objectives.The additions of Cumulo's WebSocket, RPC, and gRPC endpoints enhance the documentation by providing users with more options for connecting to the Celestia network. The changes are consistent with the existing format and use appropriate protocols and ports.
|
gm @santosdios can you pull in latest main to resolve conflicts? |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (3)
nodes/mainnet.md (3)
Line range hint
46-86: Approved: Detailed explanation of network parameters addedThe addition of detailed information about maximum bytes and calculations for maximum block size is valuable for users and developers. The mathematical formulas and explanations provide a clear understanding of the network's limitations and capabilities.
Consider adding a brief explanation of what PFB stands for in the line "One share is reserved for the PFB transaction" to improve clarity for readers who might not be familiar with the acronym.
Line range hint
103-118: Approved: Production RPC endpoints and usage warning addedThe addition of a table listing production RPC providers with their respective URLs is valuable for users deploying in production environments. The warning about not relying on free community endpoints for production deployments is an important precaution that enhances the overall reliability of the documentation.
For consistency, consider using the same format for all URLs in the table. For example, the NewMetric URL could be updated to remove the "https://" prefix to match the format of the other URLs.
Line range hint
284-302: Approved: Additional explorer and analytics resourcesThe expansion of the explorers and analytics sections with new websites enhances the resources available to users for monitoring and analyzing the Celestia network. This addition improves the overall utility of the documentation.
For consistency, consider adding brief descriptions or categorizations for each explorer and analytics website. This would help users quickly identify which resource best suits their needs.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- nodes/mainnet.md (1 hunks)
🔇 Additional comments (2)
nodes/mainnet.md (2)
Line range hint
131-153: Approved: Additional community consensus RPC endpointsThe expansion of the community consensus RPC endpoints list is beneficial for users, providing more options for connecting to the network. This addition enhances the overall accessibility and robustness of the Celestia network.
Line range hint
1-310: Overall assessment: Significant improvements to Mainnet Beta documentationThe changes made to this file substantially enhance the Celestia Mainnet Beta documentation. Key improvements include:
- Detailed explanations of network parameters and maximum byte calculations.
- Addition of production RPC endpoints with appropriate usage warnings.
- Expansion of community consensus RPC, API, gRPC, and WebSocket endpoints.
- Inclusion of new explorer and analytics resources.
These changes align well with the PR objectives and provide valuable information for users and developers interacting with the Celestia network. The documentation is now more comprehensive and user-friendly.
| - `wss://rpc.celestia.mainnet.dteam.tech:443/websocket` | ||
| - `wss://celestia.cumulo.org.es:443/websocket` |
There was a problem hiding this comment.
💡 Codebase verification
Issues Found with New WebSocket Endpoints
The newly added WebSocket endpoints could not be connected successfully:
wss://celestia-ws.chainode.tech:33373/websocketwss://celestia-mainnet-ws.itrocket.net:443/websocketwss://rpc.celestia.mainnet.dteam.tech:443/websocketwss://celestia.cumulo.org.es:443/websocket
Please verify that these URLs are correct and that the endpoints are accessible.
🔗 Analysis chain
Approved: New WebSocket endpoints added
The addition of new WebSocket endpoints enhances the connectivity options for users and aligns with the PR objective of adding WebSocket endpoints for Cumulo. This improvement contributes to the overall functionality of the Celestia network.
To ensure the consistency and validity of the new WebSocket endpoints, let's verify their format and accessibility:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the format and accessibility of the new WebSocket endpoints
# Test: Check if the URLs follow the expected format
echo "Checking URL format..."
grep -E '^- `wss://.*:.*(/websocket)?`$' nodes/mainnet.md
# Test: Attempt to establish a WebSocket connection (Note: This is a basic check and may not work in all environments)
echo "Attempting to connect to WebSocket endpoints..."
for url in $(grep -oP '(?<=`wss://).*(?=/websocket`)' nodes/mainnet.md); do
echo "Checking $url..."
timeout 5 websocat "wss://$url/websocket" 2>/dev/null || echo "Failed to connect to $url"
done
Length of output: 1932
|
I hope it will be OK some days I hate GitHub :-) |
|
same lol!! |
Overview
Summary by CodeRabbit
New Features
Documentation