Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WebSocket endpoints Cumulo #1741

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Add WebSocket endpoints Cumulo #1741

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7596d02
Update mainnet.md
santosdios Sep 30, 2024
0f89b38
Merge branch 'main' into main
santosdios Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions nodes/mainnet.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,8 @@ on [service providers with SLAs](#production-rpc-endpoints).

- `wss://celestia-ws.chainode.tech:33373/websocket`
- `wss://celestia-mainnet-ws.itrocket.net:443/websocket`
- `wss://rpc.celestia.mainnet.dteam.tech:443/websocket`
- `wss://celestia.cumulo.org.es:443/websocket`
Comment on lines +199 to +200
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Issues Found with New WebSocket Endpoints

The newly added WebSocket endpoints could not be connected successfully:

  • wss://celestia-ws.chainode.tech:33373/websocket
  • wss://celestia-mainnet-ws.itrocket.net:443/websocket
  • wss://rpc.celestia.mainnet.dteam.tech:443/websocket
  • wss://celestia.cumulo.org.es:443/websocket

Please verify that these URLs are correct and that the endpoints are accessible.

🔗 Analysis chain

Approved: New WebSocket endpoints added

The addition of new WebSocket endpoints enhances the connectivity options for users and aligns with the PR objective of adding WebSocket endpoints for Cumulo. This improvement contributes to the overall functionality of the Celestia network.

To ensure the consistency and validity of the new WebSocket endpoints, let's verify their format and accessibility:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the format and accessibility of the new WebSocket endpoints

# Test: Check if the URLs follow the expected format
echo "Checking URL format..."
grep -E '^- `wss://.*:.*(/websocket)?`$' nodes/mainnet.md

# Test: Attempt to establish a WebSocket connection (Note: This is a basic check and may not work in all environments)
echo "Attempting to connect to WebSocket endpoints..."
for url in $(grep -oP '(?<=`wss://).*(?=/websocket`)' nodes/mainnet.md); do
    echo "Checking $url..."
    timeout 5 websocat "wss://$url/websocket" 2>/dev/null || echo "Failed to connect to $url"
done

Length of output: 1932


### Data availability nodes

Expand Down
Loading