Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mocha archive endpoints #1791

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Update mocha archive endpoints #1791

merged 1 commit into from
Nov 18, 2024

Conversation

santosdios
Copy link
Contributor

@santosdios santosdios commented Nov 13, 2024

Overview

Summary by CodeRabbit

  • New Features
    • Added new RPC, API, and gRPC endpoints for the Mocha testnet to enhance connectivity options.
  • Documentation
    • Updated the how-to guide to include details on the new endpoints and their usage.

Copy link
Contributor

coderabbitai bot commented Nov 13, 2024

Walkthrough

The document how-to-guides/mocha-testnet.md has been updated to include new community RPC, API, and gRPC endpoints for the Mocha testnet. The changes consist of the addition of three specific endpoints: one for RPC, one for API, and one for gRPC. The overall structure and guidance of the document remain unchanged, focusing on how to connect to various types of nodes and the importance of using reliable endpoints for production environments.

Changes

File Change Summary
how-to-guides/mocha-testnet.md Added new community RPC endpoint: rpc.archive.mocha.cumulo.com.es
Added new community API endpoint: https://api.archive.mocha.cumulo.com.es
Added new community gRPC endpoint: grpc.archive.mocha.cumulo.com.es:443

Possibly related PRs

Suggested reviewers

  • jcstein
  • mindstyle85

🐇 In the garden of code, we hop and play,
New endpoints sprout, brightening the way.
With RPC, API, and gRPC in sight,
Connecting to Mocha feels just right!
So gather 'round, dear friends, let’s cheer,
For the changes made, we hold so dear! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
how-to-guides/mocha-testnet.md (1)

124-124: Consider documenting the purpose of archive endpoints

The addition of three new endpoints with the "archive" designation suggests a new service type, but there's no explanation of their specific purpose, retention policy, or any differences from regular endpoints.

Consider adding a new section or note that explains:

  • The purpose and benefits of archive endpoints
  • Any differences in data retention or availability
  • Specific use cases where these endpoints should be preferred
  • Any limitations or considerations when using these endpoints

Also applies to: 145-145, 169-169

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 4b55bf3 and cf3f64f.

📒 Files selected for processing (1)
  • how-to-guides/mocha-testnet.md (3 hunks)
🔇 Additional comments (3)
how-to-guides/mocha-testnet.md (3)

145-145: Verify the new API endpoint's SSL certificate and availability

The new API endpoint follows the correct format and uses HTTPS, but we should verify its SSL certificate and availability.

#!/bin/bash
# Description: Verify the new API endpoint's SSL certificate and basic functionality
# Test the endpoint's SSL certificate and response

echo "Testing SSL certificate..."
curl -sI https://api.archive.mocha.cumulo.com.es | grep -i "HTTP\|SSL"

echo "Testing API availability..."
curl -s https://api.archive.mocha.cumulo.com.es/cosmos/base/tendermint/v1beta1/node_info | jq .

124-124: Verify the new RPC endpoint's availability

The new RPC endpoint follows the correct format, but we should verify its availability and response time.

✅ Verification successful

The RPC endpoint is available and operational

The endpoint rpc.archive.mocha.cumulo.com.es is verified to be active and properly configured based on the successful API response from the same domain. The node is running on the correct network (mocha-4) with the expected configuration.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the new RPC endpoint's availability and basic functionality
# Test the endpoint's response using the basic /health endpoint

curl -s "https://rpc.archive.mocha.cumulo.com.es:26657/health" | jq .

Length of output: 30637


169-169: Verify the new gRPC endpoint and consider documentation enhancement

The new gRPC endpoint follows the correct format and uses the standard secure port (443). However, we should verify its consistency with the other new archive endpoints.

Consider adding a note in the documentation about the purpose of these archive endpoints and any specific use cases or limitations they may have.

✅ Verification successful

Let me verify the endpoint by checking for other similar archive endpoints in the documentation.


The gRPC endpoint is consistent with other archive endpoints

The new gRPC endpoint grpc.archive.mocha.cumulo.com.es:443 follows the same subdomain pattern as the other archive endpoints in the same document (rpc.archive.mocha.cumulo.com.es and api.archive.mocha.cumulo.com.es). The endpoint is correctly formatted and uses the standard secure port 443.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the new gRPC endpoint's availability
# Test the endpoint using grpcurl (if available in the environment)

# Verify DNS resolution and port accessibility
nc -zv grpc.archive.mocha.cumulo.com.es 443 2>&1

Length of output: 30637


Script:

#!/bin/bash
# Search for similar archive endpoints in the documentation
rg -i "archive.*\.cumulo\.com" --type md

Length of output: 297

@jcstein jcstein merged commit f69fe62 into celestiaorg:main Nov 18, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants