Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Typographical and Inconsistency Errors in Documentation #1792

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

voronor
Copy link
Contributor

@voronor voronor commented Nov 14, 2024

This pull request addresses the following issues found in the documentation:

  1. Typo in how-to-guides/docker-images.md:

    • Before: "For security purposes Celestia expects to interact with the your node's keys in a read-only manner."
    • After: "For security purposes Celestia expects to interact with your node's keys in a read-only manner."
    • Explanation: The phrase "the your" is grammatically incorrect and has been corrected to "your" to maintain clarity and proper grammar.
  2. Inconsistent usage of "fallback" in how-to-guides/ethereum-fallback.md:

    • Before: In some places, it is written as "fallback" and in others as "fall back" (two words).
    • After: All instances of "fall back" have been corrected to "fallback" to maintain consistency throughout the document.
    • Explanation: Inconsistent terminology can lead to confusion, and standardizing the usage of "fallback" ensures better clarity and alignment across the documentation.
  3. Correction in how-to-guides/network-upgrade-process.md:

    • Before: "Upgrades using in-protocol signaling (v3+) activate one week after 5/6 of the voting power has signaled for a particular version."
    • After: "Upgrades using in-protocol signaling (v3+) activate one week after 5/6 of the voting power have signaled for a particular version."
    • Explanation: The phrase "has signaled" was incorrect as it referred to "5/6 of the voting power," which is plural. The correction ensures subject-verb agreement, improving the grammatical accuracy of the text.

These changes are important for improving the clarity, consistency, and grammatical correctness of the documentation, helping users better understand the processes and instructions provided.

Summary by CodeRabbit

  • Documentation
    • Improved clarity and readability of the Docker images guide.
    • Corrected terminology in the Ethereum fallback document.
    • Detailed the Celestia network upgrade process, introducing the Lemongrass upgrade and outlining coordination methods for upgrades.

The phrase "the your" corrected to "your".
The word "fallback" is used inconsistently. In some places, it is written as "fallback" and in others as "fall back" (two words). Fixed.
Corrected has signaled to have signaled
Copy link
Contributor

coderabbitai bot commented Nov 14, 2024

Walkthrough

The pull request includes modifications to several documentation files, enhancing clarity and correcting minor errors. Key changes involve rephrasing sections for better readability, formatting code blocks consistently, and expanding instructions on node initialization. The updates also address terminology corrections and provide detailed explanations regarding the Celestia network upgrade process, particularly the Lemongrass upgrade and its coordination methods.

Changes

File Change Summary
how-to-guides/docker-images.md Improved clarity, corrected minor errors, rephrased introduction, formatted instructions consistently, and clarified node initialization steps.
how-to-guides/ethereum-fallback.md Changed "fall back" to "fallback" and explained the Ethereum fallback mechanism with visual representation.
how-to-guides/network-upgrade-process.md Detailed the Celestia network upgrade process, introduced the Lemongrass upgrade, and clarified signaling methods for validators.

Possibly related issues

  • Info on lemongrass hard-fork #1638: The changes provide clarity on the Lemongrass upgrade, which is relevant to the information needed for validators regarding the upcoming changes in celestia-app v2.

Possibly related PRs

Suggested labels

documentation, enhancement

Suggested reviewers

  • jcstein
  • rootulp
  • cmwaters

🐇 In the garden where changes bloom,
Clarity grows, dispelling the gloom.
Docker commands now shine so bright,
With Lemongrass upgrades, all feels right.
Hop along, dear friends, let’s celebrate,
For knowledge shared is truly great! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
how-to-guides/docker-images.md (1)

259-259: Minor punctuation and article suggestions

The grammatical correction from "the your" to "your" looks good! Consider these minor improvements for even better readability:

-For security purposes Celestia expects to interact with your node's
+For security purposes, Celestia expects to interact with your node's

Also, consider adding "the" before "filesystem" in the following sentence to maintain proper article usage.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 4b55bf3 and 7faef48.

📒 Files selected for processing (3)
  • how-to-guides/docker-images.md (1 hunks)
  • how-to-guides/ethereum-fallback.md (1 hunks)
  • how-to-guides/network-upgrade-process.md (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • how-to-guides/ethereum-fallback.md
🔇 Additional comments (1)
how-to-guides/network-upgrade-process.md (1)

16-16: LGTM! Grammar and terminology are correct.

The sentence properly uses "have signaled" with the plural subject (5/6 of validators), fixing the subject-verb agreement. The terminology is also consistent with the rest of the document's discussion of the in-protocol signaling mechanism.

Let's verify the consistency of terminology usage throughout the document:

✅ Verification successful

Terminology and grammar usage is consistent across the documentation

The verification confirms that there is only one instance of this terminology in the markdown documentation, and it correctly uses "have signaled" with the plural subject "5/6 of validators". No inconsistencies were found.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for consistent usage of "have/has signaled" terminology
# Expected: Only plural form "have signaled" should be used with "5/6 of validators"

rg -i "of validators.*(has|have) signal" --type md

Length of output: 333

Copy link
Member

@jcstein jcstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@jcstein jcstein merged commit 7e3f620 into celestiaorg:main Nov 18, 2024
2 checks passed
Copy link

gitpoap-bot bot commented Nov 18, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 Celestia Contributor:

GitPOAP: 2024 Celestia Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants