-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Typographical and Inconsistency Errors in Documentation #1792
Conversation
The phrase "the your" corrected to "your".
The word "fallback" is used inconsistently. In some places, it is written as "fallback" and in others as "fall back" (two words). Fixed.
Corrected has signaled to have signaled
WalkthroughThe pull request includes modifications to several documentation files, enhancing clarity and correcting minor errors. Key changes involve rephrasing sections for better readability, formatting code blocks consistently, and expanding instructions on node initialization. The updates also address terminology corrections and provide detailed explanations regarding the Celestia network upgrade process, particularly the Lemongrass upgrade and its coordination methods. Changes
Possibly related issues
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
how-to-guides/docker-images.md (1)
259-259
: Minor punctuation and article suggestionsThe grammatical correction from "the your" to "your" looks good! Consider these minor improvements for even better readability:
-For security purposes Celestia expects to interact with your node's +For security purposes, Celestia expects to interact with your node'sAlso, consider adding "the" before "filesystem" in the following sentence to maintain proper article usage.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (3)
how-to-guides/docker-images.md
(1 hunks)how-to-guides/ethereum-fallback.md
(1 hunks)how-to-guides/network-upgrade-process.md
(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- how-to-guides/ethereum-fallback.md
🔇 Additional comments (1)
how-to-guides/network-upgrade-process.md (1)
16-16
: LGTM! Grammar and terminology are correct.
The sentence properly uses "have signaled" with the plural subject (5/6 of validators), fixing the subject-verb agreement. The terminology is also consistent with the rest of the document's discussion of the in-protocol signaling mechanism.
Let's verify the consistency of terminology usage throughout the document:
✅ Verification successful
Terminology and grammar usage is consistent across the documentation
The verification confirms that there is only one instance of this terminology in the markdown documentation, and it correctly uses "have signaled" with the plural subject "5/6 of validators". No inconsistencies were found.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for consistent usage of "have/has signaled" terminology
# Expected: Only plural form "have signaled" should be used with "5/6 of validators"
rg -i "of validators.*(has|have) signal" --type md
Length of output: 333
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2024 Celestia Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
This pull request addresses the following issues found in the documentation:
Typo in
how-to-guides/docker-images.md
:Inconsistent usage of "fallback" in
how-to-guides/ethereum-fallback.md
:Correction in
how-to-guides/network-upgrade-process.md
:These changes are important for improving the clarity, consistency, and grammatical correctness of the documentation, helping users better understand the processes and instructions provided.
Summary by CodeRabbit