-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: test og fix again #1795
style: test og fix again #1795
Conversation
WalkthroughThe changes in this pull request primarily involve modifications to the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
.vitepress/config.ts (2)
57-70
: Consider enhancing Twitter card metadataWhile the Twitter card configuration is good, consider adding these missing meta tags for better social sharing:
twitter:title
twitter:description
["meta", { name: "twitter:card", content: "summary_large_image" }], ["meta", { name: "twitter:site", content: "@CelestiaOrg" }], ["meta", { name: "twitter:site:domain", content: "docs.celestia.org" }], ["meta", { name: "twitter:url", content: "https://docs.celestia.org" }], + ["meta", { name: "twitter:title", content: "Celestia Docs" }], + ["meta", { name: "twitter:description", content: "The first modular blockchain network." }], [ "meta", { name: "twitter:image", content: "https://docs.celestia.org/Celestia-og.png", }, ], ["meta", { name: "twitter:image:alt", content: "Celestia Documentation" }],
71-83
: Consider using dynamic base URL for image pathsThe Open Graph configuration is comprehensive, but the image URL could be made dynamic using the base URL configuration.
[ "meta", { property: "og:image", - content: "https://docs.celestia.org/Celestia-og.png", + content: `${base}Celestia-og.png`, }, ],
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (1)
public/Celestia-og.png
is excluded by!**/*.png
📒 Files selected for processing (1)
.vitepress/config.ts
(2 hunks)
🔇 Additional comments (1)
.vitepress/config.ts (1)
28-30
: LGTM: Favicon configuration follows best practices
The favicon configuration provides both SVG and PNG formats with appropriate MIME types for optimal browser compatibility.
Overview
Summary by CodeRabbit