Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update storage dependencies for FN and BN #947

Merged
merged 9 commits into from
Aug 23, 2023
Merged

docs: update storage dependencies for FN and BN #947

merged 9 commits into from
Aug 23, 2023

Conversation

jcstein
Copy link
Member

@jcstein jcstein commented Aug 16, 2023 •
edited
Loading

Overview

Resolves #946

  • (1) check on validator/full consensus node updates (if any)
  • (2) update graphic

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2023 •
edited
Loading

PR Preview Action v1.4.4
🚀 Deployed preview to https://celestiaorg.github.io/docs/pr-preview/pr-947/
on branch gh-pages at 2023-08-22 14:32 UTC

@jcstein jcstein self-assigned this Aug 16, 2023
Wondertan
Wondertan reviewed Aug 17, 2023
View reviewed changes
docs/nodes/bridge-node.mdx Show resolved Hide resolved
docs/nodes/bridge-node.mdx Outdated Show resolved Hide resolved
@jcstein
Copy link
Member Author

jcstein commented Aug 17, 2023 •
edited
Loading

current second draft cc @Wondertan

node-requirements

@jcstein jcstein requested a review from Wondertan August 17, 2023 16:57
@jcstein jcstein added the documentation Improvements or additions to documentation label Aug 17, 2023
@jcstein jcstein marked this pull request as ready for review August 17, 2023 16:57
@jcstein jcstein requested a review from Bidon15 August 17, 2023 16:58
Bidon15
Bidon15 reviewed Aug 18, 2023
View reviewed changes
Copy link
Member

@Bidon15 Bidon15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend 5-10 Tb for DA bridge nodes and DA full nodes. For consensus part 1 Tb is fine as long as people prune

Memory wise - 32 Gib is fine for now, but once we get to 128 ods blocks (256 eds blocks) -> this is not ok.

@jcstein
Copy link
Member Author

jcstein commented Aug 21, 2023 •
edited
Loading

I'd recommend 5-10 Tb for DA bridge nodes and DA full nodes

would you lean toward 5 or 10 as the default recommendation?

@jcstein jcstein requested review from Bidon15 and tty47 August 21, 2023 14:50
@jcstein jcstein requested a review from MSevey August 21, 2023 21:12
tty47
tty47 approved these changes Aug 22, 2023
View reviewed changes
Copy link

@tty47 tty47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪨

@Bidon15
Copy link
Member

Bidon15 commented Aug 22, 2023

I'd recommend 5-10 Tb for DA bridge nodes and DA full nodes

would you lean toward 5 or 10 as the default recommendation?

Can we have 5Tb as min and 10 Tb as recommended? 🙏

@jcstein
Copy link
Member Author

jcstein commented Aug 22, 2023 •
edited
Loading

Can we have 5Tb as min and 10 Tb as recommended? 🙏

yes @Bidon15 - will update text now. in the graphic, would you like just 5 Tb or also show 10 Tb recommendation?

@Bidon15
Copy link
Member

Bidon15 commented Aug 22, 2023

Having recommended field will help a lot like we have in the gaming realm.
Thanks for uploading a new version of the graphic. You 🪨 @jcstein

@jcstein
Copy link
Member Author

jcstein commented Aug 22, 2023

thanks @Bidon15, you 🪨 too. confirming that you'd like recommended on the graphic?

@jcstein jcstein mentioned this pull request Aug 23, 2023
Closed
@jcstein jcstein merged commit b764527 into main Aug 23, 2023
4 checks passed
@jcstein jcstein deleted the jcs/update-fn-bn-specs branch August 23, 2023 15:34
@Bidon15
Copy link
Member

Bidon15 commented Aug 24, 2023

confirming that you'd like recommended on the graphic?

Ideally yes. But we can do it later ™️ @jcstein

@jcstein jcstein mentioned this pull request Aug 24, 2023
Closed
@jcstein
Copy link
Member Author

jcstein commented Aug 24, 2023

hi i wanted to get this out the door, opened up #986 to track it

jcstein added a commit to jcstein/docs that referenced this pull request Sep 18, 2023
@jcstein
docs: update storage dependencies for FN and BN (celestiaorg#947)
4f6ca1d 
* docs: update storage dependencies for FN and BN

* update graphic

* add suggestions from code review

* Update full-storage-node.mdx

* Update node-requirements.jpg

* apply suggestions from code review

* add feedback from devops

* apply suggestions from review from @Bidon15

* swap graphic
jcstein added a commit that referenced this pull request Sep 21, 2023
@jcstein
docs: update storage dependencies for FN and BN (#947)
7fafad6 
* docs: update storage dependencies for FN and BN

* update graphic

* add suggestions from code review

* Update full-storage-node.mdx

* Update node-requirements.jpg

* apply suggestions from code review

* add feedback from devops

* apply suggestions from review from @Bidon15

* swap graphic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSevey MSevey MSevey left review comments

@tty47 tty47 tty47 approved these changes

@renaynay renaynay Awaiting requested review from renaynay

@Wondertan Wondertan Awaiting requested review from Wondertan

@Bidon15 Bidon15 Awaiting requested review from Bidon15

Assignees

@jcstein jcstein

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update specs to be at least 24GB RAM for FN and BN
5 participants
@jcstein @Bidon15 @MSevey @Wondertan @tty47