Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor sidecars to an inetrface #431

Closed
Tracked by #495
, #488
...
mojtaba-esk opened this issue Jun 6, 2024 · 0 comments · Fixed by #443
Closed
Tracked by #495
, #488
...

Refactor sidecars to an inetrface #431

mojtaba-esk opened this issue Jun 6, 2024 · 0 comments · Fixed by #443
Assignees
@mojtaba-esk
Labels
knuu refactor Refactoring
Milestone
v0.15.0

Comments

@mojtaba-esk
Copy link
Member

Currently we have a multiple predefined sidecars that user can enable including: OtelCollector, TsharkCollector, BitTwister, and there might be more in future.
to have a clean code base with a nice structure, let's define the sidecar as an interface that each new sidecar implements it. it enhances also the composeability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mojtaba-esk mojtaba-esk

Labels
knuu refactor Refactoring
Projects
Celestia DevOps/Testing
Archived in project
Milestone
v0.15.0
Development

Successfully merging a pull request may close this issue.

refactor!: sidecars to inetrface celestiaorg/knuu
2 participants
@mojtaba-esk @smuu