Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider renaming TestScope field in knuu struct for more clarity #456

Closed
Tracked by #488
mojtaba-esk opened this issue Jun 25, 2024 · 3 comments
Closed
Tracked by #488
Assignees
Labels
knuu refactor Refactoring
Milestone

Comments

@mojtaba-esk
Copy link
Member

currently in knuu options and systemDependencies there is a TestScope fdield:

type Options struct {
	K8sClient    k8s.KubeManager
	MinioClient  *minio.Minio
	ImageBuilder builder.Builder
	TestScope    string
	ProxyEnabled bool
	Timeout      time.Duration
	Logger       *logrus.Logger
}

type SystemDependencies struct {
	ImageBuilder builder.Builder
	K8sClient    k8s.KubeManager
	MinioClient  *minio.Minio
	Logger       *logrus.Logger
	Proxy        *traefik.Traefik
	TestScope    string
	StartTime    string
}

to avoid confusion, let's rename it to Scope. There is also a DefaultTestScope() func that needs to be renamed too.

@tty47
Copy link
Contributor

tty47 commented Jul 23, 2024

hello! is this one done by: #503 or are there any other things to check?

@smuu
Copy link
Member

smuu commented Jul 23, 2024

There was a PR that is merged: #504

There are reasons that it was merged into #503 (which I forgot), and it seems that GitHub did not resolve the issue.

@tty47
Copy link
Contributor

tty47 commented Jul 23, 2024

closing as done

@tty47 tty47 closed this as completed Jul 23, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Celestia DevOps/Testing Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
knuu refactor Refactoring
Projects
Archived in project
Development

No branches or pull requests

3 participants