Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor batch destroy #337

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

mojtaba-esk
Copy link
Contributor

This PR suggests a refactor for batch destroy instances to have more concise clean up functions in the tests.

@mojtaba-esk mojtaba-esk requested a review from a team May 15, 2024 11:36
@mojtaba-esk mojtaba-esk self-assigned this May 15, 2024
Copy link
Member

@smuu smuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very helpful 🚀

@mojtaba-esk mojtaba-esk merged commit 2dcd7ac into main May 16, 2024
3 of 4 checks passed
@mojtaba-esk mojtaba-esk deleted the mojtaba/refactor-batch-destroy branch May 16, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants