feat!: rejects invalid empty range proofs #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staheri14
changed the title
Codecov Report
@@ Coverage Diff @@
## master #180 +/- ##
==========================================
+ Coverage 94.04% 94.09% +0.05%
==========================================
Files 5 5
Lines 537 542 +5
==========================================
+ Hits 505 510 +5
Misses 18 18
Partials 14 14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
staheri14
changed the title
rootulp
previously approved these changes
Apr 25, 2023
evan-forbes
previously approved these changes
Apr 25, 2023
cmwaters
previously approved these changes
Apr 25, 2023
proof.go
Outdated
Comment on lines
109
to
110
| // IsOfEmptyProof checks whether the proof corresponds to an empty proof as defined in NMT specifications https://github.com/celestiaorg/nmt/blob/master/docs/spec/nmt.md. | ||
| func (proof Proof) IsOfEmptyProof() bool { |
There was a problem hiding this comment.
Suggested change
| // IsOfEmptyProof checks whether the proof corresponds to an empty proof as defined in NMT specifications https://github.com/celestiaorg/nmt/blob/master/docs/spec/nmt.md. | |
| func (proof Proof) IsOfEmptyProof() bool { | |
| // IsEmptyProof checks whether the proof corresponds to an empty proof as defined in NMT specifications https://github.com/celestiaorg/nmt/blob/master/docs/spec/nmt.md. | |
| func (proof Proof) IsEmptyProof() bool { |
nit
There was a problem hiding this comment.
Thank you for your suggestion. The reason behind this naming is to maintain consistency with the IsOfAbsence() function, that implements a similar logic.
There was a problem hiding this comment.
Oh, I see your point, renamed it in 9e3d8de
rootulp
approved these changes
Apr 25, 2023
evan-forbes
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Resolves #164
Checklist