Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replaces redundant codes in the HashNode with a proper function call #190

Merged
merged 3 commits into from
May 5, 2023

Conversation

staheri14
Copy link
Contributor

@staheri14 staheri14 commented May 4, 2023

Overview

Closes #130

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@staheri14 staheri14 self-assigned this May 4, 2023
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #190 (37e614d) into master (f6e7254) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #190      +/-   ##
==========================================
- Coverage   95.74%   95.71%   -0.04%     
==========================================
  Files           5        5              
  Lines         564      560       -4     
==========================================
- Hits          540      536       -4     
  Misses         14       14              
  Partials       10       10              
Impacted Files Coverage Δ
hasher.go 97.60% <100.00%> (-0.08%) ⬇️

@staheri14 staheri14 marked this pull request as ready for review May 4, 2023 18:57
@staheri14 staheri14 merged commit 4b97a09 into master May 5, 2023
@staheri14 staheri14 deleted the removes-duplicate-codes branch May 5, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplication of code
3 participants