chore(deps): bump golangci/golangci-lint-action from 3 to 4 #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3 to 4. - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](golangci/golangci-lint-action@v3...v4) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
|
The following labels could not be found: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #245 +/- ##
=======================================
Coverage 68.30% 68.30%
=======================================
Files 6 6
Lines 1325 1325
=======================================
Hits 905 905
Misses 403 403
Partials 17 17 ☔ View full report in Codecov by Sentry. |
rootulp
requested changes
Feb 12, 2024
There was a problem hiding this comment.
LGTM but looks like the version bump surfaced some new Go lint warnings that we need to fix: https://github.com/celestiaorg/nmt/actions/runs/7850055522/job/21424715999?pr=245
rootulp
reviewed
Feb 12, 2024
| @@ -1,7 +1,7 @@ | |||
| # Namespaced Merkle Tree (NMT) | |||
|
|
|||
|  | |||
| [](https://pkg.go.dev/github.com/celestiaorg/nmt) | |||
| [](https://pkg.go.dev/github.com/celestiaorg/nmt) | |||
There was a problem hiding this comment.
the previous link was failing markdown lint CI
rootulp
approved these changes
Feb 12, 2024
staheri14
approved these changes
Feb 12, 2024
rootulp
deleted the
dependabot/github_actions/golangci/golangci-lint-action-4
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps golangci/golangci-lint-action from 3 to 4.
Release notes
Sourced from golangci/golangci-lint-action's releases.
... (truncated)
Commits
3cfe3a4build(deps): bump@actions/cachefrom 3.2.3 to 3.2.4 (#963)cbc59cfbuild(deps-dev): bump prettier from 3.2.4 to 3.2.5 (#960)459a04bbuild(deps-dev): bump@typescript-eslint/eslint-pluginfrom 6.19.1 to 6.20.0 ...e2315b6build(deps-dev): bump@typescript-eslint/parserfrom 6.19.1 to 6.20.0 (#961)d6173a4build(deps): bump@types/nodefrom 20.11.10 to 20.11.16 (#962)0e8f5bfbuild(deps): bump@types/nodefrom 20.11.5 to 20.11.10 (#958)349d206build(deps-dev): bump@typescript-eslint/eslint-pluginfrom 6.19.0 to 6.19.1 ...2221aeebuild(deps-dev): bump@typescript-eslint/parserfrom 6.18.1 to 6.19.1 (#954)3b44ae5build(deps-dev): bump@typescript-eslint/eslint-pluginfrom 6.18.1 to 6.19.0 ...323b871build(deps-dev): bump prettier from 3.2.2 to 3.2.4 (#950)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)