-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create utilities module which is neccessary to fix #104 #115
Open
rluedde
wants to merge
11
commits into
cenpy-devs:master
Choose a base branch
from
rluedde:numeric_cols_104
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Jul 13, 2020
-
There were functions in products.py that will be useful in other modules but circular imports pop up if these functions don't have their own module.
Configuration menu - View commit details
-
Copy full SHA for 1699383 - Browse repository at this point
Copy the full SHA 1699383View commit details -
_ACS_MISSING only gets used once (in a function that's now in utilities.py so I moved this variable into that function. I don't think that these missing values ever change
Configuration menu - View commit details
-
Copy full SHA for 1808453 - Browse repository at this point
Copy the full SHA 1808453View commit details -
Try to convert all data columns to ints
If one of the columns can' be converted, none of the columns get converted.
Configuration menu - View commit details
-
Copy full SHA for bc28c5a - Browse repository at this point
Copy the full SHA bc28c5aView commit details
Commits on Jul 16, 2020
-
Coerce casts what it can and not all-or-none
utilities._coerce used to take in an object and try to change the entire object's dtype. Now, it changes only what columns can be changeable. For example, if there's a column of words and column of integers, coerce cam now cast only the column of integers to type integer and leave the column of words as pandas objects. Add unit tests for coerce.
reilley committedJul 16, 2020 Configuration menu - View commit details
-
Copy full SHA for 74b449c - Browse repository at this point
Copy the full SHA 74b449cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f2640b - Browse repository at this point
Copy the full SHA 1f2640bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d35e12 - Browse repository at this point
Copy the full SHA 1d35e12View commit details
Commits on Jul 17, 2020
-
replace_missing (the argument) had the same name as replace_missing (the function)
Configuration menu - View commit details
-
Copy full SHA for ad58c75 - Browse repository at this point
Copy the full SHA ad58c75View commit details
Commits on Jul 19, 2020
-
Fix uppercase/lowercase apply_func bug
This fix likely causes a lot of other issues with functions in this module. Tests will probably be a good idea at some point here.
Configuration menu - View commit details
-
Copy full SHA for 403e595 - Browse repository at this point
Copy the full SHA 403e595View commit details
Commits on Aug 15, 2020
-
Merge branch 'numeric_cols_104' of https://github.com/rluedde/cenpy i…
…nto rep_col_cases_114
Configuration menu - View commit details
-
Copy full SHA for 3489b78 - Browse repository at this point
Copy the full SHA 3489b78View commit details -
Configuration menu - View commit details
-
Copy full SHA for ac0f845 - Browse repository at this point
Copy the full SHA ac0f845View commit details -
Configuration menu - View commit details
-
Copy full SHA for dcbfb8a - Browse repository at this point
Copy the full SHA dcbfb8aView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.