Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create utilities module which is neccessary to fix #104 #115

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Commits on Jul 13, 2020

  1. Create utilities module

    There were functions in products.py that will be useful in other modules
    but circular imports pop up if these functions don't have their own module.
    rluedde committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    1699383 View commit details
    Browse the repository at this point in the history
  2. Fix _ACS_MISSING location

    _ACS_MISSING only gets used once (in a function that's now in utilities.py
    so I moved this variable into that function. I don't think that these
    missing values ever change
    rluedde committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    1808453 View commit details
    Browse the repository at this point in the history
  3. Try to convert all data columns to ints

    If one of the columns can' be converted, none of the columns get converted.
    rluedde committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    bc28c5a View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2020

  1. Coerce casts what it can and not all-or-none

    utilities._coerce used to take in an object and try to change the
    entire object's dtype. Now, it changes only what columns can be
    changeable.
    
    For example, if there's a column of words and column of integers,
    coerce cam now cast only the column of integers to type integer
    and leave the column of words as pandas objects.
    
    Add unit tests for coerce.
    reilley committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    74b449c View commit details
    Browse the repository at this point in the history
  2. Implement replace_missing recursively

    Add tests
    rluedde committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    1f2640b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1d35e12 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2020

  1. Fix name duplication

    replace_missing (the argument) had the same name as replace_missing
    (the function)
    rluedde committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    ad58c75 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2020

  1. Fix uppercase/lowercase apply_func bug

    This fix likely causes a lot of other issues with functions in this module.
    Tests will probably be a good idea at some point here.
    rluedde committed Jul 19, 2020
    Configuration menu
    Copy the full SHA
    403e595 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2020

  1. Configuration menu
    Copy the full SHA
    3489b78 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ac0f845 View commit details
    Browse the repository at this point in the history
  3. Call utilities correctly

    rluedde committed Aug 15, 2020
    Configuration menu
    Copy the full SHA
    dcbfb8a View commit details
    Browse the repository at this point in the history