-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cephfs: no need to check for zero volume size #2472
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be good to give a reference to the CSI spec and/or the implementation where the creation of a 0 size volume is prevented.
@nixpanic Its actually at CO side, the pvc creation fail like this:
|
Not sure a |
Pull request has been modified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit still mentions
creation with size 0 fail from the api validation itself
which might only be correct for Kubernetes, it is better to mention that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit still mentions
creation with size 0 fail from the api validation itself
which might only be correct for Kubernetes, it is better to mention that
This still needs addressing?
Pull request has been modified.
@nixpanic may be final look ? :) |
@nixpanic ptal.. thanks ! |
At present there is a 'todo' to check for zero volume size in the createVolume request which in unwanted, ie the pvc creation with size 0 fail from the kubernetes api validation itself: For ex: ``` ..spec.resources[storage]: Invalid value: "0": must be greater than zero``` ``` so we dont need any extra check in the controller server Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Signed-off-by: Humble Chirammal hchiramm@redhat.com