-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rbd-nbd: network block device (NBD) support for RBD #6657
Conversation
I have try to rebase and repush multi times, and the jenkin failure with different problem. |
@wwformat Try running |
@wwformat you can verify if it's a false negative by rebasing and repushing, this will trigger another run. It is possible that something in your environment is making the test pass. You could try to run-make-check.sh on a fresh virtual machine to verify it is not the case. If you have docker installed, you can also create a docker container from the ceph/src directory with: test/docker-test.sh --os-type centos --os-version 7 --shell this will give you a container and a separate source directory at the same commit your working tree is in. When you have the shell, you can ./run-make-check.sh (that's actually what the bot does). Warning: this will use ~10GB of additional disk space. |
Signed-off-by: Yunchuan Wen <yunchuan.wen@kylin-cloud.com> Signed-off-by: Li Wang <li.wang@kylin-cloud.com>
Signed-off-by: Yunchuan Wen <yunchuan.wen@kylin-cloud.com>
Signed-off-by: Yunchuan Wen <yunchuan.wen@kylin-cloud.com>
Signed-off-by: Yunchuan Wen <yunchuan.wen@kylin-cloud.com> Reviewed-by: Li Wang <li.wang@kylin-cloud.com>
Signed-off-by: Yunchuan Wen <yunchuan.wen@kylin-cloud.com>
Signed-off-by: Yunchuan Wen <yunchuan.wen@kylin-cloud.com>
The class SubProcess will use std::cerr, but not include the header. Signed-off-by: Yunchuan Wen <yunchuan.wen@kylin-cloud.com>
Signed-off-by: Yunchuan Wen <yunchuan.wen@kylin-cloud.com>
@dillaman serveral days ago, we received notification from Github saying that our KylinStorage team has been deleted for unknown reason, we recreated it, unfortunately found that we can not use 'push -f' to update the commits under the original PR, therefore we had to start a new pull request, sorry for the inconvenience |
Signed-off-by: Yunchuan Wen <yunchuan.wen@kylin-cloud.com>
Signed-off-by: Yunchuan Wen <yunchuan.wen@kylin-cloud.com>
Signed-off-by: Yunchuan Wen <yunchuan.wen@kylin-cloud.com>
Signed-off-by: Yunchuan Wen <yunchuan.wen@kylin-cloud.com>
@dillaman thanks for your review. |
rbd-nbd: network block device (NBD) support for RBD Reviewed-by: Jason Dillaman <dillaman@redhat.com>
This is rbd client in userspace (refer to rbd-nbd), as an alternative to kernel rbd client
(refer to rbd-ker). The motivation are as follows,
(1) The developement of rbd-ker is behind that of userspace librbd;
(2) The flexibility and portability (dependent on kernel version) of rbd-ker are not very good;
(3) More importantly, according to our experience on ARM64 architecture for container scenario,
there exists stability issue for rbd-ker, easily cause kernel hang or disk-utils 100%;
(4) Rely on powerful librbd, rbd-nbd enjoys extremely simple code, and easy to maintain and
make stable, and will not cause system unusable even if crashed (which we do not meet in our
test);
(5) According to our test, the performance of rbd-nbd is comparable to rbd-ker;
(6) For the container sinaro, rbd-nbd is very practical.
The usage of rbd-nbd is very simple, rbd-nbd map/unmap/list-mapped, the other functions still
leave rbd to do.