Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.15] Fix incorrect value and indentation of the PodMonitor endpointAdditionalProperties #7191

Merged
merged 1 commit into from
Jul 21, 2024
Merged

[release-1.15] Fix incorrect value and indentation of the PodMonitor endpointAdditionalProperties #7191

merged 1 commit into from
Jul 21, 2024

Conversation

inteon
Copy link
Member

@inteon inteon commented Jul 19, 2024

Manual backport of #7069 (review) and #7190.

Kind

/kind bug

Release Note

Fix incorrect value and indentation of `endpointAdditionalProperties` in the `PodMonitor` template of the Helm chart

@wallrj @inteon
Fix incorrect value and indentation of the PodMonitor endpointAdditio…
ae55ea1 
…nalProperties template in the Helm chart

Signed-off-by: Richard Wall <richard.wall@venafi.com>
@inteon inteon requested a review from wallrj July 19, 2024 09:22
@cert-manager-prow cert-manager-prow bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. area/deploy Indicates a PR modifies deployment configuration size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 19, 2024
@maelvls
Copy link
Member

maelvls commented Jul 21, 2024

I haven't tested this backport commit. I trust the testing that was performed in #7190 😇

/lgtm
/approve

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2024
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maelvls

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2024
@cert-manager-prow cert-manager-prow bot merged commit a4338af into cert-manager:release-1.15 Jul 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallrj wallrj Awaiting requested review from wallrj

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/deploy Indicates a PR modifies deployment configuration dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@inteon @maelvls @wallrj