Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm updates for istiod cert #355

Merged
merged 3 commits into from
Jul 22, 2024
Merged

Helm updates for istiod cert #355

merged 3 commits into from
Jul 22, 2024

Conversation

SgtCoDFish
Copy link
Member

See individual commits for more details and justification.

Summary:

  1. istio (upstream) uses "signature algorithm" frequently when it means "private key algorithm". We copy that for our "signature algorithm" value. Added a warning about that to avoid confusion.
  2. Adds some comments and updates value descriptions to make what's happening clearer
  3. Adds the ability to choose a private key algorithm for the istiod cert. Currently, it's only configurable globally for all kinds of certs.

@SgtCoDFish
re-order istiod helm values
ab43386 
1. ensure that enable is the first option
2. add description for renewBefore

Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
@SgtCoDFish
add comments explaining dict logic in cert template
c4f7569 
Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
@SgtCoDFish
allow manual specification of istiod cert key algo
229b5a7 
also update comments on various values

Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 22, 2024
@ThatsMrTalbot
Copy link
Contributor

/lgtm

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2024
@SgtCoDFish
Copy link
Member Author

/approve

@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2024
@cert-manager-prow cert-manager-prow bot merged commit cc9f32a into cert-manager:main Jul 22, 2024
12 checks passed
@SgtCoDFish SgtCoDFish deleted the istiodhelm branch July 22, 2024 13:20
@wallrj wallrj mentioned this pull request Dec 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SgtCoDFish @ThatsMrTalbot