Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker image with cmrel and release-notes #32

Closed
wants to merge 2 commits into from
Closed

Docker image with cmrel and release-notes #32

wants to merge 2 commits into from

Conversation

maelvls
Copy link
Member

@maelvls maelvls commented May 19, 2021 •
edited
Loading

Fixes #31.

@jakexks Is it OK if I publish the cmrel images to ghcr.io?

Usage:

docker build . -t cmrel
docker run -it cmrel cmrel 
docker run -it cmrel release-notes

@maelvls
docker image with cmrel and release-notes
07cc528 
Signed-off-by: Maël Valais <mael@vls.dev>
@jetstack-bot jetstack-bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label May 19, 2021
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maelvls

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 19, 2021
@maelvls
release-tools: publish images to ghcr.io
db06849 
Signed-off-by: Maël Valais <mael@vls.dev>
@maelvls maelvls force-pushed the container-with-release-tools branch from 59bf63c to db06849 Compare May 19, 2021 09:22
@jakexks
Copy link
Member

jakexks commented May 19, 2021

/test pull-cert-manager-release-verify

@maelvls
Copy link
Member Author

maelvls commented Jun 1, 2021

Since we realized that just containerizing won't be as simple, I'll create another PR later.

/close

@jetstack-bot
Copy link
Contributor

@maelvls: Closed this PR.

In response to this:

Since we realized that just containerizing won't be as simple, I'll create another PR later.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move the manual steps of our release process to cmrel commands
3 participants
@maelvls @jetstack-bot @jakexks