Data validation function #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Internal function to check that covariates exist in the dataset provided. Test updated to incorporate this.
certara-jcraig
requested changes
Dec 11, 2023
There was a problem hiding this comment.
Thanks @certara-mtalley , just some minor changes requested, see comments. Let's additionally add this data validation function inside generate_residualsplots and generate_residualsplots2 (I updated ticket with additional scope).
Updated data validation function. Added it to other functions. Updated tests accordingly.
certara-jcraig
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Looks good, approving and merging - thanks @certara-mtalley
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal function to check that covariates exist in the dataset provided. Test updated to incorporate this.