This repository has been archived by the owner on Dec 4, 2018. It is now read-only.
Remove use of threads when retrieving layers #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes the use of multiple threads when retrieving layer JSON. Instead of spawning a new thread for each of the ten layers that need to be retrieved on a request, the layers are retrieved sequentially. While this may have the effect of slowing down data retrieval somewhat, it greatly simplifies how predictably this code can be expected to run in a web server.
rosskarchner
approved these changes
Dec 20, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the use of multiple threads when retrieving layer JSON. Instead of spawning a new thread for each of the ten layers that need to be retrieved on a request, the layers are retrieved sequentially.
While this may have the effect of slowing down data retrieval somewhat, it simplifies how predictably this code can be expected to run in a web server. This PR is intended for use alongside #845 which removes dependence on an external API entirely, instead making calls via Python directly.
The best way to test this is either with a local setup with regulations-core with a complete production database or by pointing your
EREGS_API_BASEto a live endpoint with loaded regs:Click around a complex reg, e.g. somewhere in Reg Z and observe how long it takes to load the content. Compare with the
masterbranch to see how much of an impact this change has.