This repository has been archived by the owner on Dec 4, 2018. It is now read-only.
Use nvm explicitly to enforce npm version #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change modifies how the Node version is specified in the Travis CI build. The "nodejs: 6" entry in .travis.yml wasn't properly setting the Node version to the desired 6.x version. This was causing problems because Travis was using Node 8.x, which modified the npm-shrinkwrap.json file. This in turn created a "dirty" git state which caused release wheels to be named improperly. Ping @higs4281 who I know was experiencing something similar in another repository. This repository should probably be upgraded to explicitly use Node 8 instead of Node 6, but that is left for a future effort.
Turned out to be a local issue. |
anselmbradford
approved these changes
Jan 4, 2018
|
@anselmbradford yes, thanks! |
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change modifies how the Node version is specified in the Travis CI build. The
"nodejs: 6"entry in.travis.ymlwasn't properly setting the Node version to the desired 6.x version. This was causing problems because Travis was using Node 8.x, which modified thenpm-shrinkwrap.jsonfile. This in turn created a "dirty" git state which caused release wheels to be named improperly.Ping @higs4281 who I know was experiencing something similar in another repository.
This repository should probably be upgraded to explicitly use Node 8 instead of Node 6, but that is left for a future effort.