add envvar to test with binary_mode and add some more tests

.travis.yml

@@ -54,6 +54,7 @@ env:
 
 script:
  - go test -v ./...
+ - PGTEST_BINARY_MODE=on go test -v ./...
 
 before_script:
  - psql -c 'create database pqgotest' -U postgres

conn.go

@@ -594,7 +594,6 @@ func (cn *conn) readExecuteResponse(protocolState string) (res driver.Result, co
 	}
 }
 
-
 func (cn *conn) simpleExec(q string) (res driver.Result, commandTag string, err error) {
 	b := cn.writeBuf('Q')
 	b.string(q)
@@ -748,8 +747,8 @@ func (cn *conn) Query(query string, args []driver.Value) (_ driver.Rows, err err
 
 		st.exec(args)
 		return &rows{
-			cn: cn,
-			cols: st.cols,
+			cn:      cn,
+			cols:    st.cols,
 			rowTyps: st.rowTyps,
 		}, nil
 	}
@@ -1306,8 +1305,8 @@ func (st *stmt) Query(v []driver.Value) (r driver.Rows, err error) {
 
 	st.exec(v)
 	return &rows{
-		cn: st.cn,
-		cols: st.cols,
+		cn:      st.cn,
+		cols:    st.cols,
 		rowTyps: st.rowTyps,
 	}, nil
 }
@@ -1412,11 +1411,11 @@ func (cn *conn) parseComplete(commandTag string) (driver.Result, string) {
 }
 
 type rows struct {
-	cn *conn
-	cols []string
+	cn      *conn
+	cols    []string
 	rowTyps []oid.Oid
-	done bool
-	rb   readBuf
+	done    bool
+	rb      readBuf
 }
 
 func (rs *rows) Close() error {

conn_test.go

@@ -7,6 +7,7 @@ import (
 	"io"
 	"os"
 	"reflect"
+	"strings"
 	"testing"
 	"time"
 )
@@ -15,6 +16,10 @@ type Fatalistic interface {
 	Fatal(args ...interface{})
 }
 
+func forceBinaryMode() bool {
+	return os.Getenv("PGTEST_BINARY_MODE") == "on"
+}
+
 func openTestConnConninfo(conninfo string) (*sql.DB, error) {
 	datname := os.Getenv("PGDATABASE")
 	sslmode := os.Getenv("PGSSLMODE")
@@ -32,6 +37,10 @@ func openTestConnConninfo(conninfo string) (*sql.DB, error) {
 		os.Setenv("PGCONNECT_TIMEOUT", "20")
 	}
 
+	if forceBinaryMode() && !strings.HasPrefix(conninfo, "postgres://") {
+		conninfo = conninfo + " binary_mode=on"
+	}
+
 	return sql.Open("postgres", conninfo)
 }
 

encode_test.go

@@ -407,13 +407,13 @@ func TestByteaToText(t *testing.T) {
 	b := []byte("hello world")
 	row := db.QueryRow("SELECT $1::text", b)
 
-	var result []byte
+	var result string
 	err := row.Scan(&result)
 	if err != nil {
 		t.Fatal(err)
 	}
 
-	if string(result) != string(b) {
+	if result != string(b) {
 		t.Fatalf("expected %v but got %v", b, result)
 	}
 }
@@ -436,6 +436,69 @@ func TestTextToBytea(t *testing.T) {
 	}
 }
 
+func TestByteaToUUID(t *testing.T) {
+	if forceBinaryMode() {
+		t.Skip("ByteaToUUID is intended to fail with binary_mode")
+	}
+	db := openTestConn(t)
+	defer db.Close()
+
+	b := []byte("a0eebc99-9c0b-4ef8-bb6d-6bb9bd380a11")
+	row := db.QueryRow("SELECT $1::uuid", b)
+
+	var result []byte
+	err := row.Scan(&result)
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	if string(result) != string(b) {
+		t.Fatalf("expected %v but got %v", b, result)
+	}
+}
+
+func TestStringToUUID(t *testing.T) {
+	db := openTestConn(t)
+	defer db.Close()
+
+	s := "a0eebc99-9c0b-4ef8-bb6d-6bb9bd380a11"
+	row := db.QueryRow("SELECT $1::uuid", s)
+
+	var result string
+	err := row.Scan(&result)
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	if result != s {
+		t.Fatalf("expected %v but got %v", s, result)
+	}
+}
+
+func TestByteaToInt(t *testing.T) {
+	db := openTestConn(t)
+	defer db.Close()
+
+	expected := 12345678
+	b := []byte(fmt.Sprintf("%d", expected))
+	row := db.QueryRow("SELECT $1::int", b)
+
+	var result int
+	err := row.Scan(&result)
+	if forceBinaryMode() {
+		if err == nil {
+			t.Fatalf("Expected error on query")
+		}
+	} else {
+		if err != nil {
+			t.Fatal(err)
+		}
+		if result != expected {
+			t.Fatalf("expected %v but got %v", expected, result)
+		}
+	}
+}
+
 func TestByteaOutputFormatEncoding(t *testing.T) {
 	input := []byte("\\x\x00\x01\x02\xFF\xFEabcdefg0123")
 	want := []byte("\\x5c78000102fffe6162636465666730313233")