Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The bodyAfter element is present whilst items are animating #84

Closed
guywillis opened this issue Apr 24, 2024 · 1 comment · Fixed by #85
Closed

The bodyAfter element is present whilst items are animating #84

guywillis opened this issue Apr 24, 2024 · 1 comment · Fixed by #85
Assignees
@danielghost
Labels
bug released

Comments

@guywillis
Copy link
Contributor

Subject of the issue

If the plugin has a bodyAfter element and is configured to animate the items in then the bodyAfter element visually looks odd as it appears on screen before the items have started / finished animating as the bodyAfter element has no animation delay tied to it.

Your environment

  • Master
@guywillis guywillis added the bug label Apr 24, 2024
@danielghost danielghost self-assigned this Apr 24, 2024
danielghost added a commit that referenced this issue May 1, 2024
@danielghost
Fix: display bodyAfter once list items have animated (fixes #84).
f719a44
@danielghost danielghost mentioned this issue May 1, 2024
Merged
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 5.4.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielghost danielghost

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: postpone bodyAfter display until list items have animated cgkineo/adapt-list
2 participants
@danielghost @guywillis