Skip to content

Commit

Permalink
ci(): reintroduce node 14 testing (fabricjs#8232)
Browse files Browse the repository at this point in the history
  • Loading branch information
ShaMan123 authored and frankrousseau committed Jan 6, 2023
1 parent a377f54 commit 5438071
Show file tree
Hide file tree
Showing 4 changed files with 46 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
# For more information see:
# https://help.github.com/actions/language-and-framework-guides/using-nodejs-with-github-actions
# supported Node.js release schedule: https://nodejs.org/en/about/releases/
node-version: [16.x]
node-version: [14.x, 16.x]
suite: [unit, visual]
steps:
- uses: actions/checkout@v2
Expand Down
37 changes: 37 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@
"@types/node": "^17.0.21",
"@typescript-eslint/eslint-plugin": "^5.29.0",
"@typescript-eslint/parser": "^5.29.0",
"abort-controller": "^3.0.0",
"auto-changelog": "^2.3.0",
"busboy": "^1.6.0",
"chalk": "^2.4.1",
Expand Down
7 changes: 7 additions & 0 deletions test/node_test_setup.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,13 @@ var chalk = require('chalk');
var diff = require('deep-object-diff').diff;
var commander = require('commander');

// TODO remove block and dependency when node 14 fades out
// node 14 AbortController polyfill for tests
if (!global.AbortController) {
require("abort-controller/polyfill");
}


commander.program
.option('-d, --debug', 'debug visual tests by overriding refs (golden images) in case of visual changes', false)
.option('-r, --recreate', 'recreate visual refs (golden images)', false)
Expand Down

0 comments on commit 5438071

Please sign in to comment.