Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alias for contain and include #327

Closed
lo1tuma opened this issue Dec 22, 2014 · 2 comments
Closed

Add alias for contain and include #327

lo1tuma opened this issue Dec 22, 2014 · 2 comments

Comments

@lo1tuma
Copy link
Contributor

lo1tuma commented Dec 22, 2014

It would be nice to have a contains and includes alias for contain and include.
So you can write the following assertion:

expect(someObject).to.have.property('someProperty').that.contains('anyString');
@keithamus
Copy link
Member

Thanks for the issue @lo1tuma, seems like a sensible and straightforward request. Here's where include and contain are defined - so it should be trivial to simply copy those two lines to provide includes and contains. If you have the time to make a pull request then you'll get the credit and end up in our hall of amazing contributors.

@lo1tuma
Copy link
Contributor Author

lo1tuma commented Dec 24, 2014

@keithamus thanks, working on it.

keithamus added a commit that referenced this issue Dec 27, 2014
Add includes and contains alias (fixes #327)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants