Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added assert.notOk() #171

Merged
merged 2 commits into from
Jun 9, 2013
Merged

Added assert.notOk() #171

merged 2 commits into from
Jun 9, 2013

Conversation

Bartvds
Copy link
Contributor

@Bartvds Bartvds commented Jun 8, 2013

Of course we currently could do assert.ok(!actual) but that's breaking the descriptive symmetry of the negations compared with the other assertions.

I also added tests but it looks like the documentation is in the other repos. I can edit that as well after you accept this edit.

This would close #165

@Bartvds
Copy link
Contributor Author

Bartvds commented Jun 8, 2013

I ran node's mocha which passes the tests but I see travis balks on the browser tests. I'm on windows so I cannot run make to verify this (no grunt love here? :).

@logicalparadox
Copy link
Member

The code looks like it should work, but please fix your formatting to match the style guidelines. Mocha-phantomjs hasn't been behaving as of late so I will see what I can do about that.

The API documentation is automatically generated from the comment block you have already included so the website will be updated when I release. No need to edit the chai-docs repo unless there is something specific you want to include in a tutorial.

@Bartvds
Copy link
Contributor Author

Bartvds commented Jun 8, 2013

I should've spotted that in the diff, as I had my editor mis-configured. I pushed a fix.

Maybe travis fails because I don't commit any build output files? I was looking into setting up VirtualBox so I can make() stuff but I had to navigate some roadblocks so that'll take a bit longer.

@logicalparadox
Copy link
Member

Actually travis/make is configured to handle all the build output files itself and you should NOT be committing them in PRs. I think mocha or mocha-phantomjs is having issues... we had to downgrade our mocha recently due to incompatibility but perhaps it has resurfaced. I will look into it further.

logicalparadox added a commit that referenced this pull request Jun 9, 2013
@logicalparadox logicalparadox merged commit bfa6493 into chaijs:master Jun 9, 2013
@logicalparadox
Copy link
Member

Released with 1.7.0. View the release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logically missing inverse of assert.ok()
2 participants