-
-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deep equality check for collection membership #228
Conversation
This PR fails on Travis. It seems to be due to a karma problem which we have fixed in master. Can you please rebase upstream? Furthermore, please include a failing and a negation test case for your new assertion. Thanks. |
Rebased and added new test cases. #230 applies to the
Additionally, this PR only adds the deep object comparison behavior when the For example, with this PR, the following test passes. expect([{ id: 1 }]).deep.include.members([{ id: 1 }]); // passes While this test does not. expect([{ id: 1 }]).include.members([{ id: 1 }]); // fails |
Ah fantastic! Thank you. One final thing... can you update the inline comment for I just release |
I updated the inline documentation to include a |
Additionally, I actually think #230 is a little over-reaching. I like having strict-equality comparison available and exposing the more computationally-expensive and conceptually-fuzzier deep-equality through assertion flags. |
Deep equality check for collection membership
Looks great, merged. Also, fair point about #230. Will investigate and discuss. |
Support deep equality comparison for collection membership.