Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gno support #392

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

Gno support #392

wants to merge 28 commits into from

Conversation

giansalex
Copy link
Contributor

@giansalex giansalex commented May 18, 2022

  • New feature gno
  • Gno Account
  • Gno amino signature
  • Gno Tx broadcast
  • Render custom MsgSend, VmCall
  • Tx tracer

Vm call demo:
image

giansalex and others added 9 commits May 19, 2022 19:27
 Conflicts:
	packages/background/src/chains/types.ts
	packages/background/src/keyring/service.ts
	packages/extension/src/stores/root.tsx
	packages/proto-types/outputHash
	packages/stores/src/account/cosmos.ts
@giansalex
Copy link
Contributor Author

giansalex commented Aug 16, 2022

+GNO Testnet ChainInfo

const chainInfo = {
    "chainId": "test2",
    "chainName": "GNO Testnet",
    "rpc": "https://rpc.gno.tools",
    "rest": "https://lcd.gno.tools",
    "stakeCurrency": {
        "coinDenom": "GNOT",
        "coinMinimalDenom": "ugnot",
        "coinDecimals": 6
    },
    "bip44": {
        "coinType": 118
    },
    "bech32Config": {
        "bech32PrefixAccAddr": "g",
        "bech32PrefixAccPub": "gpub",
        "bech32PrefixValAddr": "gvaloper",
        "bech32PrefixValPub": "gvaloperpub",
        "bech32PrefixConsAddr": "gvalcons",
        "bech32PrefixConsPub": "gvalconspub"
    },
    "currencies": [
        {
            "coinDenom": "GNOT",
            "coinMinimalDenom": "ugnot",
            "coinDecimals": 6
        }
    ],
    "feeCurrencies": [
        {
            "coinDenom": "GNOT",
            "coinMinimalDenom": "ugnot",
            "coinDecimals": 6
        }
    ],
    "gasPriceStep": {
        "low": 0.00000000000001,
        "average": 0.00000000000001,
        "high": 0.00000000000001
    },
    "features": [
        "gno"
    ]
};

keplr.experimentalSuggestChain(chainInfo);

@sascha1337
Copy link

thanks gian this is really usefull

@giansalex
Copy link
Contributor Author

giansalex commented Aug 17, 2022

I've been testing, and it's working properly, including other chains.
tomorrow will probably be ready for review

@giansalex
Copy link
Contributor Author

uploading demos

gno-transfer.mp4
gno-post.mp4

@giansalex
Copy link
Contributor Author

I also found a issue when messages are very long (length > 4k), the notification is not displayed.

@giansalex giansalex marked this pull request as ready for review August 20, 2022 19:49
@giansalex
Copy link
Contributor Author

Hello @Thunnini, I think this is ready, it will be very useful to have this integration complete for GNO apps.
let me know if you have suggestions

@Thunnini
Copy link
Member

@giansalex Are there ways to test GNO on keplr? TBH, I don't follow up the status of GNO chain. Is there a testnet?

@giansalex
Copy link
Contributor Author

@Thunnini , you can test here https://app.gno.tools/transfer , it supports keplr with the latest GNO testnet.

Faucet: https://test2.gno.land/faucet

 Conflicts:
	packages/background/src/chains/types.ts
@giansalex
Copy link
Contributor Author

@Thunnini , I resolved merge conflict with master branch, let me know if you have any problems with gnoland testnet.

@Thunnini
Copy link
Member

Hey, I haven't forgotten this. Another milestone is being processed. I'm sure to check next week and merge if there are no problems

 Conflicts:
	docs/api/suggest-chain.md
	packages/background/src/chains/types.ts
	packages/extension/src/stores/root.tsx
@giansalex
Copy link
Contributor Author

I added the balance validation on MsgSend.

image

@Thunnini
Copy link
Member

Thunnini commented Oct 4, 2022

@giansalex Apologies for the late review on this. One of the biggest problem I’m facing right now is that I do not know anything about Gno. I did check that your code works fine in the testnet. But AFAIK, Jae did not like protobuf and I thought grpc would not be a part of the chain. Also, when I checked on the repo, I wasn’t able to find any traces of grpc. But on your code, it queries via existing grpc gateway endpoint. Are you sure this works well in mainnet as well? Where would I be able to locate this part in the gno repo?

@giansalex
Copy link
Contributor Author

@Thunnini , for queries like balance and txs broadcast, I have used this repo to match cosmos-sdk endpoints.
mainnet is not closed yet, any new changes will be reviewed before launch.

@zivkovicmilos
Copy link

Hey @Thunnini,

Are you still open to the gno team adding Gno support in Keplr?
We can dedicate some dev time to making sure it's supported properly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants