Skip to content
This repository has been archived by the owner on Feb 6, 2023. It is now read-only.

Use pip for installing Chainer/CuPy #509

Merged
merged 1 commit into from
Jun 10, 2019
Merged

Conversation

niboshi
Copy link
Member

@niboshi niboshi commented May 8, 2019

@kmaehashi
Copy link
Member

Jenkins, test this please.

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 0cc0ece, target branch master) failed with status FAILURE.

@toslunar
Copy link
Member

toslunar commented Jun 3, 2019

Jenkins, test this please.

@toslunar toslunar self-assigned this Jun 3, 2019
@chainer-ci
Copy link
Member

Jenkins CI test (for commit 0cc0ece, target branch master) succeeded!

Copy link
Member

@toslunar toslunar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pip install prints less log than python setup.py install. How about pip install -v?

@niboshi
Copy link
Member Author

niboshi commented Jun 10, 2019

Should it be done in this PR?
If so, I want to add -v to all the "pip install" instances in this repository.

@toslunar
Copy link
Member

To me, pip install -v looks closer to python setup.py than pip install, while I don't have a good reference.

Is there a reason why pip install and python setup.py were mixed? If you are somewhat confident that the answer is no, it's reasonable to use pip install without -v in the PR.

@niboshi
Copy link
Member Author

niboshi commented Jun 10, 2019

I guess the reason was to test multiple ways of installation.
I'm pretty sure it was not for the amount of logs.

@toslunar toslunar merged commit 9e5a25a into chainer:master Jun 10, 2019
@niboshi niboshi deleted the use-pip branch June 10, 2019 05:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use pip for installing Chainer in CIs
4 participants