When ForceSplitScope flag is provided don't assume that we have non-simple parameter list #3458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@akroshg Can you please take a look? |
…imple parameter list When we force all functions to have split scope we shouldn't assume that those function have non-simple parameter list. Fixed couple of places in EmitOneFunction.
aneeshdk
force-pushed
the
ForceSplitScopeFlagIssue
branch
from
15b9e48
to
a917ce2
Compare
|
LGTM |
chakrabot
pushed a commit
that referenced
this pull request
Aug 1, 2017
…ssume that we have non-simple parameter list Merge pull request #3458 from aneeshdk:ForceSplitScopeFlagIssue When we force all functions to have split scope we shouldn't assume that those function have non-simple parameter list. Fixed couple of places in EmitOneFunction.
chakrabot
pushed a commit
that referenced
this pull request
Aug 1, 2017
…ed don't assume that we have non-simple parameter list Merge pull request #3458 from aneeshdk:ForceSplitScopeFlagIssue When we force all functions to have split scope we shouldn't assume that those function have non-simple parameter list. Fixed couple of places in EmitOneFunction.
chakrabot
pushed a commit
that referenced
this pull request
Aug 1, 2017
…lag is provided don't assume that we have non-simple parameter list Merge pull request #3458 from aneeshdk:ForceSplitScopeFlagIssue When we force all functions to have split scope we shouldn't assume that those function have non-simple parameter list. Fixed couple of places in EmitOneFunction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we force all functions to have split scope we shouldn't assume that those function have non-simple parameter list. Fixed couple of places in EmitOneFunction.