Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WASM - binary version 0xd #3491

Merged

Conversation

Cellule
Copy link
Contributor

@Cellule Cellule commented Aug 5, 2017

Stop supporting WebAssembly binary version 0x0d.
We've been supporting the binary version for a while to help minize potential testing infrastructure problems.
At this time I think we've switched to version 0x1 for long enough and we don't want to offically support version 0xd in the next release


This change is Reviewable

Copy link
Contributor

@Penguinwizzard Penguinwizzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chakrabot chakrabot merged commit ba76a8f into chakra-core:release/1.6 Aug 9, 2017
chakrabot pushed a commit that referenced this pull request Aug 9, 2017
Merge pull request #3491 from Cellule:users/micfer/wasm/version

Stop supporting WebAssembly binary version 0x0d.
We've been supporting the binary version for a while to help minize potential testing infrastructure problems.
At this time I think we've switched to version 0x1 for long enough and we don't want to offically support version 0xd in the next release
chakrabot pushed a commit that referenced this pull request Aug 10, 2017
Merge pull request #3491 from Cellule:users/micfer/wasm/version

Stop supporting WebAssembly binary version 0x0d.
We've been supporting the binary version for a while to help minize potential testing infrastructure problems.
At this time I think we've switched to version 0x1 for long enough and we don't want to offically support version 0xd in the next release
chakrabot pushed a commit that referenced this pull request Aug 10, 2017
Merge pull request #3491 from Cellule:users/micfer/wasm/version

Stop supporting WebAssembly binary version 0x0d.
We've been supporting the binary version for a while to help minize potential testing infrastructure problems.
At this time I think we've switched to version 0x1 for long enough and we don't want to offically support version 0xd in the next release
@Cellule Cellule deleted the users/micfer/wasm/version branch August 10, 2017 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants