BigInt: support increment, decrement with assign #5806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duongnhn
commented
Oct 30, 2018
| { | ||
| byteCodeGenerator->StartStatement(pnode); | ||
| const Js::OpCode op = (pnode->nop == knopDecPost) ? Js::OpCode::Sub_A : Js::OpCode::Add_A; | ||
| bool isESBigIntEnabled = byteCodeGenerator->GetScriptContext()->GetConfig()->IsESBigIntEnabled(); |
Contributor
Author
There was a problem hiding this comment.
if BigInt is considered, we generate different bytecode for post increment/decrement. Instead of: convert to number and add 1 to it, we convert value to numeric and increment it.
duongnhn
force-pushed
the
user/duongn/bigint_inc_post
branch
4 times, most recently
from
739a952 to
14a5522
Compare
…d of add_a, dec_a
duongnhn
force-pushed
the
user/duongn/bigint_inc_post
branch
from
14a5522 to
b2ee6c7
Compare
chakrabot
pushed a commit
that referenced
this pull request
Nov 2, 2018
Merge pull request #5806 from duongnhn:user/duongn/bigint_inc_post - change incr, decr post to use incr and decr without conversion instead of add_a, dec_a - change conv_num (to number) to use conv_numeric (to numeroc) according to https://tc39.github.io/proposal-bigint/#sec-tonumeric
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.